Sign review records RC-001 to RC-009 as accepted

S01 accepts the nine SQA review records. The one-person independence
limit stays recorded in each record.
No issue closed: documentation status only, no code changed.

.gitea/workflows/ci.yml

@@ -0,0 +1,26 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  checks:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+      - name: Install
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install -e ".[dev]"
+      - name: Tests
+        run: python -m pytest
+      - name: Lint
+        run: python -m ruff check src tests
+      - name: Format check
+        run: python -m ruff format --check src tests
+      - name: Types
+        run: python -m mypy src tests

README.md

@@ -79,6 +79,16 @@ python -m ruff format --check src tests
 python -m mypy src tests
 ```
 
+## Continuous integration
+
+On every push and pull request, `.gitea/workflows/ci.yml` installs the project on
+Python 3.13 and runs the same checks as above: `pytest`, `ruff check`,
+`ruff format --check` and `mypy`. To run all of them locally:
+
+```bash
+python -m pytest && python -m ruff check src tests && python -m ruff format --check src tests && python -m mypy src tests
+```
+
 ## Build the source documentation
 
 The source uses Doxygen comments. The HTML output goes to `docs/doxygen/html`.
@@ -93,9 +103,10 @@ doxygen Doxyfile
 | --- | --- |
 | `src/coffee_machine/` | The machine: `main.py` (the loop), `constants.py` (menu, coins, starting resources) |
 | `tests/` | pytest tests |
-| `docs/` | Planning and review documents (business case, plan, milestones) |
+| `docs/` | Planning documents (business case, plan, milestones) and SQA review records with the traceability matrix (`docs/sqa/`) |
 | `pyproject.toml` | Project configuration |
 | `Doxyfile` | Doxygen configuration |
+| `.gitea/workflows/` | CI workflow |
 
 ## License
 

docs/artifact-registry.md

@@ -15,7 +15,7 @@ document of a type. `Primary File` may contain a glob (e.g.
 | SA | Stakeholder Analysis | docs/stakeholder-analysis.md | 002 |
 | PP | Project Plan | docs/project-plan.md | 002 |
 | MIL | Milestone / Gateway | docs/milestones/*.md | 005 |
-| RC | SQA Review Record | docs/sqa/reviews/rc-*.md | 006 |
+| RC | SQA Review Record | docs/sqa/reviews/rc-*.md | 010 |
 | TM | Traceability Matrix | docs/sqa/traceability-matrix.md | 002 |
 
 ## Languages

docs/business-case.md

@@ -9,8 +9,8 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Added duration constraint (RC-001 action) | [8ef00aa] |
+| 2026-10-06 | Deprecated | Jens Tirsvad Nielsen | S01 | Added objective 6 and scope for code review and CI | [8ef00aa] |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Added objective 6 and scope for code review and CI | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Added success criterion 6 and clarified the Python version (RC-008 actions) | [71a27dd] |
 
 ---
 
@@ -92,6 +92,7 @@ professional project hygiene, and the goal of sharing readable solutions.
 | 3 | Runtime dependencies | 0 | `pyproject.toml` `dependencies` is empty |
 | 4 | Setup documented | A new reader can run program and tests from README | README walkthrough |
 | 5 | Repository metadata | Description and at least 3 topics set | Repository page |
+| 6 | Code reviewed and checked automatically | Source review record with verdict Go; latest CI run on `main` green | `docs/sqa/reviews/` and the CI run on the git host |
 
 ## Risks
 
@@ -108,7 +109,7 @@ professional project hygiene, and the goal of sharing readable solutions.
 
 ## Constraints
 
-- Python greater than 3.13 as requested, `venv` for environments, pytest for tests.
+- Python 3.13 or newer (the request says "greater than 3.13"; read as `>=3.13`), `venv` for environments, pytest for tests.
 - Constants live in `constants.py`.
 - Source files use Doxygen comments.
 - Nothing is committed or pushed unless the user asks.
@@ -136,3 +137,4 @@ Proceed — the scope is small, well specified and delivers a reusable example.
 
 [SA-001]: ./stakeholder-analysis.md
 [8ef00aa]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/8ef00aafaaa193ea565f1a45238d31e963a5e05d
+[71a27dd]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/71a27ddc1f5555c1b836b1556fab292ebc9deb62

docs/milestones/mil-004-code-review-and-ci.md

@@ -9,7 +9,7 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
 
 ---
 

docs/project-plan.md

@@ -9,21 +9,21 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-05 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [c0c3940] |
+| 2026-10-06 | Deprecated | Jens Tirsvad Nielsen | S01 | Added MIL-004 Code Review and CI | [8ef00aa] |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-004 Code Review and CI | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Fixed phase count, dependency overlap and stale risks and open issues (RC-009 actions) | [52b9725] |
 
 ---
 
 ## Purpose
 
-Schedule the three phases that take the coffee machine from empty repository to
+Schedule the four phases that take the coffee machine from empty repository to a
-published project, within the short assignment timeline in [BC-001].
+reviewed, published project, within the one-week duration in [BC-001].
 
 ## Planning Assumptions
 
 - Week 1 starts 2026-10-05; the plan ends by 2026-10-12.
 - Phase length: two to three days; S01 reviews each phase through a pull request (see [SA-001]).
-- Each phase is one branch and one pull request.
+- Each phase is delivered through one or more branches and pull requests.
 
 ## Gateway Schedule
 
@@ -32,7 +32,7 @@ published project, within the short assignment timeline in [BC-001].
 | Project Setup | [MIL-001] | 2026-10-05 to 2026-10-07 | 2026-10-07 | S01 | none | Skeleton, tooling, README | [Milestone 40] |
 | Coffee Machine Core | [MIL-002] | 2026-10-08 to 2026-10-10 | 2026-10-10 | S01 | none | Working program | [Milestone 41] |
 | Quality and Publication | [MIL-003] | 2026-10-11 to 2026-10-12 | 2026-10-12 | S01 | none | Tests, Doxygen, published repo | [Milestone 42] |
-| Code Review and CI | [MIL-004] | 2026-10-07 to 2026-10-12 | 2026-10-12 | S01 | none | Source review record, CI workflow | |
+| Code Review and CI | [MIL-004] | 2026-10-07 to 2026-10-12 | 2026-10-12 | S01 | none | Source review record, CI workflow | [Milestone 48] |
 
 ```plantuml
 @startgantt
@@ -65,6 +65,8 @@ Project starts 2026-10-05
 MIL-001 -> MIL-002 -> MIL-003 -> MIL-004
 ```
 
+[MIL-004] may start once the [MIL-003] tests are merged, so their windows overlap; its decision follows the decision of [MIL-003].
+
 A No-Go moves all later dates by the same amount.
 
 ## Plan Risks
@@ -72,14 +74,11 @@ A No-Go moves all later dates by the same amount.
 | Risk | Impact | Mitigation |
 | --- | --- | --- |
 | The git host has no Actions runner | CI cannot run | Check the host first; if none, keep the workflow file and document the local commands |
-| README template not supplied | README task blocked | Ask S01 for the template before the task |
 | Doxygen not installed locally | Cannot verify docs | Document the install step in README |
 
 ## Open Issues
 
-- The README template referenced in the request ("template below") was not included.
 - No use cases or user stories are written; tasks are plain technical tasks implementing the assignment specification. S01 can ask for a use case ("Order a drink") if wanted.
-- Python ">3.13" is read as 3.13 or newer (`>=3.13`).
 
 ---
 
@@ -92,5 +91,6 @@ A No-Go moves all later dates by the same amount.
 [Milestone 40]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/milestone/40
 [Milestone 41]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/milestone/41
 [Milestone 42]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/milestone/42
-[c0c3940]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/c0c3940551db0d7d96492cc734976d0436051ff9
 [8ef00aa]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/8ef00aafaaa193ea565f1a45238d31e963a5e05d
+[Milestone 48]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/milestone/48
+[52b9725]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/52b972520d33dc3b50f1c050d874aaeb7293a557

docs/sqa/reviews/rc-001-business-case.md

@@ -9,7 +9,7 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
 
 ---
 

docs/sqa/reviews/rc-002-stakeholder-analysis.md

@@ -9,7 +9,7 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
 
 ---
 

docs/sqa/reviews/rc-003-mil-001.md

@@ -9,7 +9,7 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
 
 ---
 

docs/sqa/reviews/rc-004-mil-002.md

@@ -9,7 +9,7 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
 
 ---
 

docs/sqa/reviews/rc-005-mil-003.md

@@ -9,7 +9,7 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
 
 ---
 

docs/sqa/reviews/rc-006-source-code.md

@@ -0,0 +1,54 @@
+# RC-006 Source Code Review
+
+## Metadata
+| Key | Value |
+| --- | --- |
+| ID | RC-006 |
+| CrossReference | [MIL-004], [QC-PY-001] |
+
+## Version History
+| Date | Status | Author | Reviewer | Change | Commit |
+| --- | --- | --- | --- | --- | --- |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [00d47e2] |
+
+---
+
+## Artifact Under Review
+
+- Instance reviewed: `src/coffee_machine/` and `tests/` at the state of MIL-003 (`main` after PR 22)
+- Checklist used: [QC-PY-001] (`QC-PY-001`)
+- Independence: S01 is the only stakeholder and is also the recorded author, so the reviewer-is-not-author rule cannot be met. The code and documents were written by Claude on S01's behalf; S01 reviews and signs. This is a known limit of a one-person project, not a clean independent review.
+
+## Checklist Results
+
+| # | Criterion | Status | Evidence/Notes |
+| --- | --- | --- | --- |
+| 1 | Packages, modules, functions, variables, classes and constants follow PEP 8 casing (`snake_case`, `PascalCase`, `UPPER_SNAKE`) | Pass | Modules, functions and variables are `snake_case`, constants `UPPER_SNAKE`, `Drink` is `PascalCase`. |
+| 2 | Names state purpose in the domain's language; no unexplained abbreviations, no single-letter names outside tiny scopes | Pass | Names state purpose (`is_resource_sufficient`, `process_coins`); the only short names are loop variables. |
+| 3 | Code is produced by the project's formatter and passes its linter with no unexplained suppressions | Pass | `ruff check` and `ruff format --check` pass; no suppression comments. |
+| 4 | Every function and method signature is type-annotated, including `-> None` | Pass | Every function, including tests and the nested `feed`, is annotated. |
+| 5 | No bare `except:`, no swallowed exceptions; specific exceptions are raised and the cause is kept (`raise ... from`) | Pass | No bare `except`. `_ask_coin_count` catches only `ValueError` and answers it by asking again, so nothing is swallowed. |
+| 6 | No mutable default arguments and no shadowed builtins | Pass | No mutable defaults; no builtin is shadowed. |
+| 7 | Files, locks and connections are managed with context managers | N-A | The program opens no files, locks or connections. |
+| 8 | Public modules, classes and functions have docstrings that say what, not how | Pass | All modules, public functions and tests have Doxygen docstrings that say what the code does. |
+| 9 | Logging uses `logging`, not `print`; no secrets or personal data in log output | N-A | No logging exists. `print` is the program's own console output, not diagnostics. |
+| 10 | Classes and operations trace to the Design Class Diagram they implement; deviations are recorded | N-A | No Design Class Diagram exists; the plan treats the work as plain technical tasks. |
+| 11 | Tests exist for new behaviour, are named for the behaviour, and do not depend on order or the network | Pass | 19 tests named for behaviour, independent of order, no network. |
+| 12 | Type checker runs in strict mode without errors; `Any` is justified in a comment | Pass | `mypy --strict` runs clean and `Any` is not used. |
+| 13 | Dependencies are declared and pinned in the project's dependency file, none unused | Fail | Runtime dependencies: none. The dev tools had no lower bounds for ruff and mypy; fixed by action item 1, which sets `pytest>=9`, `ruff>=0.16`, `mypy>=2.4` (the tested versions). |
+
+## Overall Verdict
+
+Go — every mandatory criterion passes or is N-A. The one Fail (13) is optional and is fixed in the same change by issue #25.
+
+## Action Items
+
+| Action | Owner | Due |
+| --- | --- | --- |
+| Set lower bounds for the dev dependencies in pyproject.toml (done) | S01 | 2026-10-06 |
+
+---
+
+[MIL-004]: ../../milestones/mil-004-code-review-and-ci.md
+[QC-PY-001]: ../../../framework/qc/qc-programming-python.md
+[00d47e2]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/00d47e244c82007bbc55e18312649189b175ec10

docs/sqa/reviews/rc-007-mil-004.md

@@ -0,0 +1,47 @@
+# RC-007 MIL-004 Review
+
+## Metadata
+| Key | Value |
+| --- | --- |
+| ID | RC-007 |
+| CrossReference | [MIL-004], [QC-MIL-001] |
+
+## Version History
+| Date | Status | Author | Reviewer | Change | Commit |
+| --- | --- | --- | --- | --- | --- |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [00d47e2] |
+
+---
+
+## Artifact Under Review
+
+- Instance reviewed: [MIL-004] (docs/milestones/mil-004-code-review-and-ci.md)
+- Checklist used: [QC-MIL-001] (`QC-MIL-001`)
+- Independence: S01 is the only stakeholder and is also the recorded author, so the reviewer-is-not-author rule cannot be met. The code and documents were written by Claude on S01's behalf; S01 reviews and signs. This is a known limit of a one-person project, not a clean independent review.
+
+## Checklist Results
+
+| # | Criterion | Status | Evidence/Notes |
+| --- | --- | --- | --- |
+| 1 | A concrete deliverable is defined for every gate | Pass | Deliverable names the RC record, the fixes, the CI workflow and the README section. |
+| 2 | Explicit Go/No-Go criteria are stated for each gate | Pass | Five Go/No-Go rows, each checkable (a record exists, a workflow runs four commands, a run is green). |
+| 3 | Dependencies on other milestones are explicitly mapped | Pass | Depends on MIL-003 with a reason. |
+| 4 | Each milestone is traceable to a Business Case objective or KPI | Pass | Traceability cites Business Case objective 6 and 4. |
+| 5 | Milestone owner and approving reviewer are identified | Pass | Owner and approving reviewer are S01 (same person; see independence note). |
+| 6 | Milestone has a defined target date consistent with project constraints | Pass | Target date 2026-10-12 lies inside the duration constraint in the Business Case. |
+
+## Overall Verdict
+
+Go — all criteria pass.
+
+## Action Items
+
+| Action | Owner | Due |
+| --- | --- | --- |
+| None | S01 | - |
+
+---
+
+[MIL-004]: ../../milestones/mil-004-code-review-and-ci.md
+[QC-MIL-001]: ../../../framework/qc/qc-milestones-gateways.md
+[00d47e2]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/00d47e244c82007bbc55e18312649189b175ec10

docs/sqa/reviews/rc-008-business-case-v3.md

@@ -0,0 +1,52 @@
+# RC-008 Business Case v3 Review
+
+## Metadata
+| Key | Value |
+| --- | --- |
+| ID | RC-008 |
+| CrossReference | [BC-001], [QC-BC-001] |
+
+## Version History
+| Date | Status | Author | Reviewer | Change | Commit |
+| --- | --- | --- | --- | --- | --- |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [861edbf] |
+
+---
+
+## Artifact Under Review
+
+- Instance reviewed: [BC-001] (docs/business-case.md, version 3 as reviewed; version 4 after the actions below)
+- Checklist used: [QC-BC-001] (`QC-BC-001`)
+- Independence: S01 is the only stakeholder and is also the recorded author, so the reviewer-is-not-author rule cannot be met. The document was written by Claude on S01's behalf; S01 reviews and signs. This is a known limit of a one-person project, not a clean independent review.
+- This record re-reviews the Business Case after version 3 added objective 6 and scope for code review and CI. It follows [RC-001], which reviewed version 2.
+
+## Checklist Results
+
+| # | Criterion | Status | Evidence/Notes |
+| --- | --- | --- | --- |
+| 1 | ROI/Cost-Benefit analysis is quantitative, or where qualitative, is explicitly justified | Pass | Cost-Benefit table is explicitly qualitative and says why. |
+| 2 | Risks are identified with documented impact and mitigation | Pass | Three risks, each with impact and mitigation. No new risk comes from objective 6. |
+| 3 | Success criteria are measurable, stating explicit targets rather than vague aspirations | Pass | Fixed in v4: objective 6 (review and CI) had no success criterion. Criterion 6 now has a target and a measure; criteria 1 to 6 are all measurable. |
+| 4 | Scope explicitly separates In Scope vs Out of Scope | Pass | `### In Scope` and `### Out of Scope` are separate; v3 added the review and CI line to In Scope and nothing contradicts Out of Scope. |
+| 5 | Stakeholders are cross-referenced to Stakeholder Analysis IDs rather than re-described inline | Pass | Stakeholders table cites S01 to S03 only. |
+| 6 | Methodology and quality-standard foundation are stated explicitly (e.g. ISO/IEC 25010, Larman) | Pass | Methodology section names the framework, ISO/IEC 25010:2023 and the coding conventions. |
+| 7 | Assumptions and constraints are explicit and clearly distinguished from one another | Pass | Fixed in v4: the Assumption said "3.13 or newer" but the Constraint said "greater than 3.13". The Constraint now states the reading (`>=3.13`). The duration constraint added after RC-001 is still present. |
+| 8 | Document supports executive decision-making with a clear, unambiguous recommendation | Pass | Recommendation is a single "Proceed" with a reason. |
+
+## Overall Verdict
+
+Go — all mandatory criteria pass. Two defects were found in version 3 (no success criterion for objective 6; conflicting wording of the Python version) and fixed in the same change as BC-001 v4.
+
+## Action Items
+
+| Action | Owner | Due |
+| --- | --- | --- |
+| Add success criterion 6 for objective 6 (done in v4) | S01 | 2026-10-06 |
+| State the Python version reading in the constraint (done in v4) | S01 | 2026-10-06 |
+
+---
+
+[BC-001]: ../../business-case.md
+[QC-BC-001]: ../../../framework/qc/qc-business-case.md
+[RC-001]: ./rc-001-business-case.md
+[861edbf]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/861edbfa92ed8b28b018c44ffd05a0b1eed035b5

docs/sqa/reviews/rc-009-project-plan-v2.md

@@ -0,0 +1,54 @@
+# RC-009 Project Plan v2 Review
+
+## Metadata
+| Key | Value |
+| --- | --- |
+| ID | RC-009 |
+| CrossReference | [PP-001] |
+
+## Version History
+| Date | Status | Author | Reviewer | Change | Commit |
+| --- | --- | --- | --- | --- | --- |
+| 2026-10-06 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [52b9725] |
+
+---
+
+## Artifact Under Review
+
+- Instance reviewed: [PP-001] (docs/project-plan.md, version 2 as reviewed; version 3 after the actions below)
+- Checklist used: none. The framework has no QC checklist for the Project Plan. The criteria below are taken from the required sections and the "Validating" note in the framework's Project Plan reference ([PP-reference]); they are an ad hoc list, not a `QC-*` checklist.
+- Independence: S01 is the only stakeholder and is also the recorded author, so the reviewer-is-not-author rule cannot be met. The document was written by Claude on S01's behalf; S01 reviews and signs. This is a known limit of a one-person project, not a clean independent review.
+
+## Checklist Results
+
+| # | Criterion | Status | Evidence/Notes |
+| --- | --- | --- | --- |
+| 1 | Purpose states what is scheduled and over what constraint | Pass | Fixed in v3: it said "three phases" and "short assignment timeline"; it now says four phases and the one-week duration in [BC-001]. |
+| 2 | Planning assumptions give the start date and phase length, consistent with the Business Case duration | Pass | Start 2026-10-05, end 2026-10-12, as in the Business Case duration constraint. Fixed in v3: "one branch and one pull request per phase" did not match what happened. |
+| 3 | Gateway Schedule has one row per MIL-* document, with its Milestone link once synced | Pass | Four rows for MIL-001 to MIL-004; Milestones 40, 41, 42 and 48 are linked. |
+| 4 | Timeline diagram has one bar per phase and a marker per Go/No-Go decision | Pass | Four bars and four markers. The diagram was not rendered: no PlantUML server is configured. |
+| 5 | Scope Coverage maps every Business Case scope item to a gateway | Pass | All six In Scope items of BC-001 v4 map to MIL-001 to MIL-004 or to planning. |
+| 6 | Dependencies state the gateway order and what a No-Go does to later dates | Pass | Fixed in v3: the chain said MIL-004 follows MIL-003 but the windows overlap. The text now says MIL-004 may start once the MIL-003 tests are merged. |
+| 7 | Plan risks are specific to the plan and each has a mitigation | Pass | Fixed in v3: the "README template not supplied" risk was resolved and was removed. Two risks remain, each with a mitigation. |
+| 8 | Open Issues lists only unresolved items | Pass | Fixed in v3: the README template and the Python version reading were resolved (README written; BC-001 v4 states the reading). One open item remains: the optional use case. |
+| 9 | CrossReference cites the Business Case, the Stakeholder Analysis and every MIL-* document, and the links are defined | Pass | BC-001, SA-001 and MIL-001 to MIL-004 are cited and defined. |
+| 10 | Windows and decision dates agree with each MIL-* Target Date and the Business Case duration | Pass | Decision dates 2026-10-07, 10-10, 10-12, 10-12 equal the Target Dates; all lie inside 2026-10-05 to 2026-10-12. |
+
+## Overall Verdict
+
+Go — every criterion passes. Five defects were found in version 2 (wrong phase count, wrong delivery assumption, dependency and window overlap, a resolved risk, resolved open issues) and fixed in the same change as PP-001 v3.
+
+## Action Items
+
+| Action | Owner | Due |
+| --- | --- | --- |
+| Correct the phase count and the delivery assumption (done in v3) | S01 | 2026-10-06 |
+| State the MIL-003/MIL-004 overlap in Dependencies (done in v3) | S01 | 2026-10-06 |
+| Remove the resolved risk and open issues (done in v3) | S01 | 2026-10-06 |
+| Ask the framework to add a QC checklist for the Project Plan (upstream) | S01 | - |
+
+---
+
+[PP-001]: ../../project-plan.md
+[PP-reference]: ../../../framework/.agents/skills/artifact/references/PP.md
+[52b9725]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/52b972520d33dc3b50f1c050d874aaeb7293a557

docs/sqa/traceability-matrix.md

@@ -9,8 +9,8 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [8ef00aa] |
+| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Business Case last reviewed in RC-008 | [71a27dd] |
-| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-004 | [8ef00aa] |
+| 2026-10-06 | Proposed | Jens Tirsvad Nielsen | S01 | Project Plan last reviewed in RC-009 | [52b9725] |
 
 ---
 
@@ -25,18 +25,19 @@ artifact instance is created or reviewed.
 | Artifact Instance | Type | Upstream (Backward Link) | Downstream (Forward Link) | Last Reviewed (RC-ID) |
 | --- | --- | --- | --- | --- |
 | [SA-001] | Stakeholder Analysis | - | [BC-001] | [RC-002] |
-| [BC-001] | Business Case | [SA-001] | [PP-001], [MIL-001], [MIL-002], [MIL-003], [MIL-004] | [RC-001] |
+| [BC-001] | Business Case | [SA-001] | [PP-001], [MIL-001], [MIL-002], [MIL-003], [MIL-004] | [RC-008] |
-| [PP-001] | Project Plan | [BC-001], [SA-001] | [MIL-001], [MIL-002], [MIL-003], [MIL-004] | - |
+| [PP-001] | Project Plan | [BC-001], [SA-001] | [MIL-001], [MIL-002], [MIL-003], [MIL-004] | [RC-009] |
 | [MIL-001] | Milestone | [BC-001], [PP-001] | - | [RC-003] |
 | [MIL-002] | Milestone | [BC-001], [PP-001] | - | [RC-004] |
 | [MIL-003] | Milestone | [BC-001], [PP-001] | - | [RC-005] |
-| [MIL-004] | Milestone | [BC-001], [PP-001] | - | - |
+| [MIL-004] | Milestone | [BC-001], [PP-001] | - | [RC-007] |
+| Source code (`src/`, `tests/`) | Source code | [MIL-002], [MIL-003], [MIL-004] | - | [RC-006] |
 
 ## Coverage Notes
 
 - `-` in Upstream means foundational; in Downstream, nothing is built on it yet; in Last Reviewed, no `RC-*` exists yet.
-- [PP-001] has no QC checklist in the framework, so it has no `RC-*`.
+- [PP-001] has no QC checklist in the framework; [RC-009] reviews it against criteria taken from the Project Plan reference.
-- No use case, domain model, design or data artifacts exist; the plan treats all tasks as plain technical tasks. The source code is covered by the tests, not by an `RC-*`.
+- No use case, domain model, design or data artifacts exist; the plan treats all tasks as plain technical tasks. The source code is reviewed in [RC-006].
 
 ---
 
@@ -47,9 +48,13 @@ artifact instance is created or reviewed.
 [MIL-002]: ../milestones/mil-002-coffee-machine-core.md
 [MIL-003]: ../milestones/mil-003-quality-and-publication.md
 [MIL-004]: ../milestones/mil-004-code-review-and-ci.md
-[RC-001]: ./reviews/rc-001-business-case.md
 [RC-002]: ./reviews/rc-002-stakeholder-analysis.md
 [RC-003]: ./reviews/rc-003-mil-001.md
 [RC-004]: ./reviews/rc-004-mil-002.md
 [RC-005]: ./reviews/rc-005-mil-003.md
-[8ef00aa]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/8ef00aafaaa193ea565f1a45238d31e963a5e05d
+[RC-006]: ./reviews/rc-006-source-code.md
+[RC-007]: ./reviews/rc-007-mil-004.md
+[RC-008]: ./reviews/rc-008-business-case-v3.md
+[RC-009]: ./reviews/rc-009-project-plan-v2.md
+[71a27dd]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/71a27ddc1f5555c1b836b1556fab292ebc9deb62
+[52b9725]: https://git.tirsystem.com/Tirsvad-Udemy-100_days_of_code/015-coffee_machine/commit/52b972520d33dc3b50f1c050d874aaeb7293a557

pyproject.toml

@@ -12,7 +12,7 @@ license = { file = "LICENSE" }
 dependencies = []
 
 [project.optional-dependencies]
-dev = ["pytest>=8", "ruff", "mypy"]
+dev = ["pytest>=9", "ruff>=0.16", "mypy>=2.4"]
 
 [project.scripts]
 coffee-machine = "coffee_machine.main:main"