MIL-004: source code review and CI #29

Merged
Tirsvad merged 2 commits from mil-004-code-review-and-ci into main 2026-10-06 14:59:33 +02:00
Owner

Adds RC-006 (source code against QC-PY-001) and RC-007 (MIL-004), and updates the traceability matrix. Sets lower bounds for the dev dependencies, the one optional Fail in RC-006; no source change was needed. Adds a Gitea Actions workflow (.gitea/workflows/ci.yml) running pytest, ruff check, ruff format --check and mypy on push and pull request, describes it in the README, accepts MIL-004 and links its Milestone in the Project Plan.

Checked locally: pytest (19 passed), ruff, ruff format --check and mypy --strict.

Notes for the reviewer:

  • The CI workflow is untested until this push; the git host has an online runner labelled ubuntu-latest. Go/No-Go criterion 4 (latest run on main is green) can only be confirmed after the merge.
  • RC-006 and RC-007, Business Case v3 and Project Plan v2 are still Proposed.
  • The reviewer-is-not-author rule cannot be met in a one-person project; each RC says so.
  • Runs of sync-github-metadata.yml on main fail; that workflow is not in this repository and is unrelated to this PR.

Closes #24
Closes #25
Closes #26
Closes #27
Closes #28

Adds RC-006 (source code against QC-PY-001) and RC-007 (MIL-004), and updates the traceability matrix. Sets lower bounds for the dev dependencies, the one optional Fail in RC-006; no source change was needed. Adds a Gitea Actions workflow (.gitea/workflows/ci.yml) running pytest, ruff check, ruff format --check and mypy on push and pull request, describes it in the README, accepts MIL-004 and links its Milestone in the Project Plan. Checked locally: pytest (19 passed), ruff, ruff format --check and mypy --strict. Notes for the reviewer: - The CI workflow is untested until this push; the git host has an online runner labelled ubuntu-latest. Go/No-Go criterion 4 (latest run on main is green) can only be confirmed after the merge. - RC-006 and RC-007, Business Case v3 and Project Plan v2 are still Proposed. - The reviewer-is-not-author rule cannot be met in a one-person project; each RC says so. - Runs of sync-github-metadata.yml on main fail; that workflow is not in this repository and is unrelated to this PR. Closes #24 Closes #25 Closes #26 Closes #27 Closes #28
Tirsvad added 2 commits 2026-10-06 14:56:22 +02:00
Review source code and add CI for MIL-004
CI / checks (push) Successful in 1m5s
00d47e244c
Add RC-006 (source code against QC-PY-001) and RC-007 (MIL-004), and
update the traceability matrix. Set lower bounds for the dev
dependencies, the one optional Fail in RC-006. Add a Gitea Actions
workflow running pytest, ruff and mypy, and describe it in the README.
Accept MIL-004 and link its Milestone in the Project Plan.

Closes #24
Closes #25
Closes #26
Closes #27
Closes #28

Task: MIL-004#1
Task: MIL-004#2
Task: MIL-004#3
Task: MIL-004#4
Task: MIL-004#5
Resolve pending commit links in MIL-004 review records
CI / checks (push) Successful in 51s
CI / checks (pull_request) Successful in 56s
f192f227e2
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Tirsvad added 1 commit 2026-10-06 14:56:22 +02:00
Resolve pending commit links in MIL-004 review records
CI / checks (push) Successful in 51s
CI / checks (pull_request) Successful in 56s
f192f227e2
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Tirsvad merged commit 58116dcb5d into main 2026-10-06 14:59:33 +02:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Tirsvad-Udemy-100-days-of-code/015-coffee-machine#29