| 1 |
Packages, modules, functions, variables, classes and constants follow PEP 8 casing (snake_case, PascalCase, UPPER_SNAKE) |
Pass |
Casing follows PEP 8. |
| 2 |
Names state purpose in the domain's language; no unexplained abbreviations, no single-letter names outside tiny scopes |
Pass |
Names state purpose (add_songs, time_travel, SongAddError). |
| 3 |
Code is produced by the project's formatter and passes its linter with no unexplained suppressions |
Pass |
ruff format and ruff check report no finding; four noqa: N803 are explained: parameter names must match ytmusicapi. |
| 4 |
Every function and method signature is type-annotated, including -> None |
Pass |
All functions annotated including -> None. |
| 5 |
No bare except:, no swallowed exceptions; specific exceptions are raised and the cause is kept (raise ... from) |
Pass |
Song errors are skipped by type, never by a bare except; authentication errors propagate; causes are kept with from. |
| 6 |
No mutable default arguments and no shadowed builtins |
Pass |
Checked in the diff. |
| 7 |
Files, locks and connections are managed with context managers |
N-A |
No files or connections are opened by the new code. |
| 8 |
Public modules, classes and functions have docstrings that say what, not how |
Pass |
Checked in the diff. |
| 9 |
Logging uses logging, not print; no secrets or personal data in log output |
Pass |
Output goes through the injected writer; nothing secret is logged. |
| 10 |
Classes and operations trace to the Design Class Diagram they implement; deviations are recorded |
N-A |
No Design Class Diagram exists; all tasks are technical. |
| 11 |
Tests exist for new behaviour, are named for the behaviour, and do not depend on order or the network |
Pass |
92 tests, 99 % coverage, no network, no real sleep (pause is injected). |
| 12 |
Type checker runs in strict mode without errors; Any is justified in a comment |
N-A |
mypy is not configured. Optional criterion. |
| 13 |
Dependencies are declared and pinned in the project's dependency file, none unused |
Pass |
Checked in the diff. |
| 14 |
Each piece of knowledge (a business rule, constant, format, validation or query) is defined in one place; code is merged only where it expresses the same knowledge, not where it merely looks alike |
Pass |
Messages, pause and status text are constants defined once. |
| 15 |
Imports point inward: business-rule modules import no framework, database, UI or delivery-mechanism code, and there are no import cycles |
Pass |
ytmusicapi is imported only in infrastructure; use cases depend on the MusicService port. |
| 16 |
SOLID holds: a class or module has one reason to change; new behaviour is added by extension, not by editing a type test in several places; subclasses honour the contract of their base; protocols are narrow; high-level code depends on protocols or abstract types and receives its implementations |
Pass |
time_travel composes use cases; MusicService stays small (five methods, each used). |
| 17 |
Source is laid out in the layers and folders of the clean architecture folder structure (domain, application, infrastructure, presentation packages under src/, and unit, integration and e2e under tests/), in snake_case, and imports between the layers point inward |
Pass |
Layer folders and tests/unit/ exist. |
| 18 |
File and folder names are English, contain no space and no character outside letters, digits, -, _ and ., and follow the casing of the language for files |
Pass |
English snake_case file names. |
