Tirsvad-Udemy-100-days-of-code/045-scrape-movies
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MIL-004: top 100 movies scraper #38

Merged
Tirsvad merged 7 commits from mil-004-top-100-movies into main 2026-10-28 07:33:37 +01:00
Conversation 0 Commits 7 Files Changed 27
+775 -85
Tirsvad commented 2026-10-28 07:31:08 +01:00
Owner
Copy Link
Copy Source

Adds the Empire page parsing (h3.title for the 2020 layout, ranked h2 headings for the live page), the reverse-and-number rule, the writer, the movies command, tests against a saved copy of the live headings, the generated movies.txt, and seven screenshots with the README section.

Known deviation: archive.org answered 429 Too Many Requests for the pinned Wayback snapshot (four polite attempts), so no snapshot fixture is committed; the snapshot layout is covered by a hand-written sample.

Closes #22
Closes #23
Closes #24
Closes #25
Closes #26
Closes #27
Closes #28

Adds the Empire page parsing (`h3.title` for the 2020 layout, ranked `h2` headings for the live page), the reverse-and-number rule, the writer, the `movies` command, tests against a saved copy of the live headings, the generated movies.txt, and seven screenshots with the README section. Known deviation: archive.org answered 429 Too Many Requests for the pinned Wayback snapshot (four polite attempts), so no snapshot fixture is committed; the snapshot layout is covered by a hand-written sample. Closes #22 Closes #23 Closes #24 Closes #25 Closes #26 Closes #27 Closes #28
Tirsvad added 7 commits 2026-10-28 07:31:10 +01:00
Add Empire fetch sources and parsing of the movie titles 6838a831ed 
Task: MIL-004#1
Task: MIL-004#2
Closes #22
Closes #23
Reverse and number the titles and write movies.txt 7d9b8b2f04 
Task: MIL-004#3
Task: MIL-004#4
Closes #24
Closes #25
Add Empire fixture and tests for the movie steps 05821ef069 
Task: MIL-004#5
Closes #26
Generate movies.txt 655aa6d180 
Task: MIL-004#6
Closes #27
Add movie screenshots and document the movie steps in README 2553960dce 
Task: MIL-004#7
Closes #28
Add code review record for MIL-004 02c339c2db
Resolve pending commit links
Quality / Quality checks (pull_request) Successful in 31s
Details
Tests and code metrics / Run pytest with coverage (pull_request) Successful in 1m5s
Details
Tests and code metrics / Code metrics badges (pull_request) Skipped
Details
English comments / english-comments (pull_request) Successful in 29s
Details
English comments / Comments are English (pull_request) Successful in 30s
Details
Quality checks / quality-checks (pull_request) Successful in 31s
Details
480f504b80
Tirsvad merged commit c29236710d into main 2026-10-28 07:33:37 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Tirsvad
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Tirsvad-Udemy-100-days-of-code/045-scrape-movies#38