Tirsvad
52afb369a7
Add FlightData.stops, check_flights(is_direct) and the indirect fallback in main. Record ADR-0001 and the code review RC-009. Task: MIL-002#1 Task: MIL-002#2 Task: MIL-002#3 Task: MIL-002#4
67 lines
3.8 KiB
Markdown
67 lines
3.8 KiB
Markdown
# SQA Review Record
|
|
|
|
## Metadata
|
|
| Key | Value |
|
|
| --- | --- |
|
|
| ID | RC-004 |
|
|
| CrossReference | [MIL-002], [QC-MIL-001], [QC-LANG-001] |
|
|
|
|
## Version History
|
|
| Date | Status | Author | Reviewer | Change | Commit |
|
|
| --- | --- | --- | --- | --- | --- |
|
|
| 2026-10-24 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version | [c5a6ed5] |
|
|
|
|
---
|
|
|
|
## Artifact Under Review
|
|
|
|
- Instance reviewed: [MIL-002]
|
|
- Checklist used: [QC-MIL-001] and [QC-LANG-001]
|
|
- Scope: full review
|
|
- Language and domain: en / it
|
|
- Language reviewer: none (the stand-in reads the language and knows the domain)
|
|
- Mode: autonomous, not independent (the reviewer is `AI as stand-in for S01`)
|
|
|
|
## Checklist Results
|
|
|
|
| # | Criterion | Status | Evidence/Notes |
|
|
| --- | --- | --- | --- |
|
|
| 1 | A concrete deliverable is defined for every gate | Pass | Deliverable section names concrete output. |
|
|
| 2 | Explicit Go/No-Go criteria are stated for each gate | Pass | Go/No-Go table has numbered, checkable criteria. |
|
|
| 3 | Dependencies on other milestones are explicitly mapped | Pass | Dependencies table present. |
|
|
| 4 | Each milestone is traceable to a Business Case objective or KPI | Pass | Traceability table maps to [BC-001] objectives. |
|
|
| 5 | Milestone owner and approving reviewer are identified | Pass | Owner and approving reviewer are S01. |
|
|
| 6 | Milestone has a defined target date consistent with project constraints | Pass | Target date set inside the 2026-10-24 to 2026-11-07 plan window. |
|
|
|
|
## Language and Domain Results
|
|
|
|
| # | Criterion | Status | Evidence/Notes |
|
|
| --- | --- | --- | --- |
|
|
| 1 | The Metadata table has a `Language` row and a `Domain` row, and neither is a placeholder | Pass | Language `en` and Domain `it` rows are in Metadata. |
|
|
| 2 | `Language` is a BCP 47 code and `Domain` is a value from the registry's domain list | Pass | `en` is BCP 47; `it` is in the registry domain list. |
|
|
| 3 | The content (prose and table cells) is written in the stated language | Pass | All prose and table cells are English. |
|
|
| 4 | The register matches the one the registry gives for the artifact type | Pass | Register matches the registry row for this type. |
|
|
| 5 | Domain terms are the PO terms of the domain's dictionary, with no synonyms | Pass | The project has no domain dictionary (DICT); the document uses standard IT terms consistently, with no synonyms. Stand-in judgement. |
|
|
| 6 | Metadata keys, section headings, IDs and statuses are in English | Pass | Metadata keys, headings, IDs and statuses are English. |
|
|
| 7 | No translated twin (`<name>.<language>.md`) exists beside the document | Pass | No translated twin exists. |
|
|
| 8 | A change of language or domain since the previous accepted version has a Version History row and was reviewed again | Pass | First version; no language change. |
|
|
| 9 | A reviewer competent in the domain, and in the language, has confirmed that the domain terms are used correctly | Pass | Confirmed by the stand-in for S01 (Product Owner, IT domain). Mode: autonomous, not independent. |
|
|
| 10 | Abbreviations are spelled out on first use, in the stated language | Fail | Optional: SMTP, API, CI and similar abbreviations are not all spelled out on first use. Action item below. |
|
|
|
|
## Overall Verdict
|
|
|
|
Go — all mandatory criteria pass; the one failed criterion is optional (QC-LANG-001 criterion 10) and has an action item.
|
|
|
|
## Action Items
|
|
|
|
| Action | Owner | Due |
|
|
| --- | --- | --- |
|
|
| Spell out the abbreviations (SMTP, API, CI, IATA) on first use in the README glossary | S01 | 2026-11-07 |
|
|
|
|
---
|
|
|
|
[MIL-002]: ../../milestones/mil-002-flight-data-and-indirect-search.md
|
|
[QC-MIL-001]: ../../../framework/qc/artifacts/qc-milestones-gateways.md
|
|
[QC-LANG-001]: ../../../framework/qc/artifacts/qc-language-domain.md
|
|
[c5a6ed5]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/040-personal-flight-club/commit/c5a6ed5985f76d8836f763acc5638053a39157f2
|