| 1 |
Packages, modules, functions, variables, classes and constants follow PEP 8 casing (snake_case, PascalCase, UPPER_SNAKE) |
Pass |
Modules, functions, variables and classes use snake_case, PascalCase and UPPER_SNAKE (STOPS_NONSTOP, is_direct). |
| 2 |
Names state purpose in the domain's language; no unexplained abbreviations, no single-letter names outside tiny scopes |
Pass |
Names state purpose (is_direct, stops, indirect_price); no cryptic abbreviations. |
| 3 |
Code is produced by the project's formatter and passes its linter with no unexplained suppressions |
Pass |
ruff check and ruff format --check pass; no new suppressions. |
| 4 |
Every function and method signature is type-annotated, including -> None |
Pass |
Every new function and test has annotations including -> None. |
| 5 |
No bare except:, no swallowed exceptions; specific exceptions are raised and the cause is kept (raise ... from) |
Pass |
No bare except and nothing swallowed; the new code adds no exception handling. |
| 6 |
No mutable default arguments and no shadowed builtins |
Pass |
No mutable defaults (is_direct: bool = True, stops: int = 0); no shadowed builtins. |
| 7 |
Files, locks and connections are managed with context managers |
Pass |
No files or connections opened by the new code; the HTTP session is unchanged. |
| 8 |
Public modules, classes and functions have docstrings that say what, not how |
Pass |
Public classes and functions carry Doxygen comments (what, not how). |
| 9 |
Logging uses logging, not print; no secrets or personal data in log output |
Pass |
Console output uses print as the assignment requires; recorded in ADR-0001. No secrets are printed. |
| 10 |
Classes and operations trace to the Design Class Diagram they implement; deviations are recorded |
Pass |
No DCD exists; the assignment's classes are the design; deviation recorded in ADR-0001. |
| 11 |
Tests exist for new behaviour, are named for the behaviour, and do not depend on order or the network |
Pass |
New behaviour is tested: stops parsing, request parameters of both searches, fallback and messages. Tests use fakes, no network, no order dependence. |
| 12 |
Type checker runs in strict mode without errors; Any is justified in a comment |
Pass |
mypy --strict passes on src and tests; the only Any is the JSON response shape. |
| 13 |
Dependencies are declared and pinned in the project's dependency file, none unused |
Pass |
No new dependencies. |
| 14 |
Each piece of knowledge (a business rule, constant, format, validation or query) is defined in one place; code is merged only where it expresses the same knowledge, not where it merely looks alike |
Pass |
The stops filter values are constants in one place; the fallback rule lives in main.run only. |
| 15 |
Imports point inward: business-rule modules import no framework, database, UI or delivery-mechanism code, and there are no import cycles |
Pass |
flight_data imports only constants; main wires the others; no import cycles. |
| 16 |
SOLID holds: a class or module has one reason to change; new behaviour is added by extension, not by editing a type test in several places; subclasses honour the contract of their base; protocols are narrow; high-level code depends on protocols or abstract types and receives its implementations |
Pass |
check_flights gains a defaulted parameter, so existing callers still work; FlightData gains a defaulted field. |
| 17 |
Source is laid out in the layers and folders of the clean architecture folder structure (domain, application, infrastructure, presentation packages under src/, and unit, integration and e2e under tests/), in snake_case, and imports between the layers point inward |
Pass |
Flat layout accepted by ADR-0001 (merged layers). |
| 18 |
File and folder names are English, contain no space and no character outside letters, digits, -, _ and ., and follow the casing of the language for files |
Pass |
File names are lower-case snake_case English with no spaces. |
