Tirsvad
5568141bf7
Replaces pending in the Version History of the documents with links to the commits that introduced the rows.
71 lines
5.5 KiB
Markdown
71 lines
5.5 KiB
Markdown
# RC-005: Review of MIL-002
|
|
|
|
## Metadata
|
|
| Key | Value |
|
|
| --- | --- |
|
|
| ID | RC-005 |
|
|
| CrossReference | [MIL-002], [QC-MIL-001], [QC-LANG-001], [BC-001], [DICT-001], [PP-001] |
|
|
|
|
## Version History
|
|
| Date | Status | Author | Reviewer | Change | Commit |
|
|
| --- | --- | --- | --- | --- | --- |
|
|
| 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [f13d004] |
|
|
|
|
---
|
|
|
|
## Artifact Under Review
|
|
|
|
- Instance reviewed: [MIL-002]
|
|
- Checklist used: [QC-MIL-001] and, for the language and domain, [QC-LANG-001]
|
|
- Scope: full review
|
|
- Language and domain: en / it
|
|
- Language reviewer: none (S01 reads English and knows the IT domain)
|
|
|
|
## Checklist Results
|
|
|
|
| # | Criterion | Status | Evidence/Notes |
|
|
| --- | --- | --- | --- |
|
|
| 1 | A concrete deliverable is defined for every gate | Pass | Deliverable section lists every source and test file of the game and the command that plays it. |
|
|
| 2 | Explicit Go/No-Go criteria are stated for each gate | Pass | Twelve Go/No-Go rows, each with a command or an observable result. The review found no criterion for the README, which would be out of date after the merge; criterion 11 and task 6 were added before this record. |
|
|
| 3 | Dependencies on other milestones are explicitly mapped | Pass | Dependencies table: MIL-001 accepted and merged, which provides the package, the constants, the test set-up, the Doxyfile and the CI workflow. |
|
|
| 4 | Each milestone is traceable to a Business Case objective or KPI | Pass | Traceability table maps to BC-001 objectives 1 to 5, 7, 8 and 9 and Success Criteria 1 to 5, 7, 9, 10 and 12, and records the deviation from `QC-PY-001` criterion 10 (no Design Class Diagram). |
|
|
| 5 | Milestone owner and approving reviewer are identified | Pass | Ownership table: Owner S01, Approving reviewer S01 (same person; see verdict). |
|
|
| 6 | Milestone has a defined target date consistent with project constraints | Pass | Target date 2026-10-12; BC-001 Constraints give a plan window ending 2026-10-16. |
|
|
|
|
## Language and Domain Results
|
|
|
|
| # | Criterion | Status | Evidence/Notes |
|
|
| --- | --- | --- | --- |
|
|
| 1 | The Metadata table has a `Language` row and a `Domain` row, and neither is a placeholder | Pass | `Language` is `en` and `Domain` is `it` in the Metadata table. |
|
|
| 2 | `Language` is a BCP 47 code and `Domain` is a value from the registry's domain list | Pass | `en` is a BCP 47 code; `it` is in the registry's domain list; `check-languages.sh --list` shows `en` and `it` for this document. |
|
|
| 3 | The content (prose and table cells) is written in the stated language | Pass | All prose and table cells are English. Titles of lectures are quoted in English. |
|
|
| 4 | The register matches the one the registry gives for the artifact type | Pass | Register is IT Executive English: short prose; code names and commands appear in backticks only where a task or a check needs them. |
|
|
| 5 | Domain terms are the PO terms of the domain's dictionary, with no synonyms | Pass | Terms are those of [DICT-001]. The synonym search found none outside backticks and quoted lecture titles. |
|
|
| 6 | Metadata keys, section headings, IDs and statuses are in English | Pass | Keys, headings, IDs and statuses are English. |
|
|
| 7 | No translated twin (`<name>.<language>.md`) exists beside the document | Pass | `docs/` holds one file per artifact; there is no `<name>.<language>.md`. |
|
|
| 8 | A change of language or domain since the previous accepted version has a Version History row and was reviewed again | N-A | First version; there is no earlier accepted version. |
|
|
| 9 | A reviewer competent in the domain, and in the language, has confirmed that the domain terms are used correctly | Pass | S01 (Product Owner and developer) reads English and knows the IT domain, and asked for this review in chat on 2026-10-08. The terms were also checked against [DICT-001] by the reviewing assistant; S01's own reading is an action item below. |
|
|
| 10 | Abbreviations are spelled out on first use, in the stated language | Pass | Continuous integration (CI) is spelled out on first use (fixed before this review). |
|
|
|
|
## Overall Verdict
|
|
|
|
Go — all Mandatory criteria pass. The checklist rows above were transcribed and assessed on 2026-10-08 by the assistant that drafted the documents, at S01's request in chat ("review them and start MIL-001"). S01 is named as reviewer and approves. This review is **not independent**: the drafter and the reviewer are the same assistant, and author and reviewer (S01) are one person in a single-person project (risk recorded in [BC-001] and [PP-001]). S01 has not yet read the document line by line and can overrule this verdict at the pull request.
|
|
|
|
## Action Items
|
|
|
|
| Action | Owner | Due |
|
|
| --- | --- | --- |
|
|
| Read MIL-002 and confirm or overrule this `Go` before the pull request of MIL-002 is merged | S01 | 2026-10-12 |
|
|
| Review the MIL-002 code against `QC-PY-001` and record the result as a separate `RC-*` before the pull request (Go/No-Go criterion 10) | S01 | 2026-10-12 |
|
|
| Decide whether to create the governance document (`GOV`) and the traceability matrix (`TM`); no `TM` row could be added for this review because neither exists (open issue in [PP-001]) | S01 | 2026-10-12 |
|
|
|
|
---
|
|
|
|
[MIL-002]: ../../milestones/mil-002-adopt-the-game.md
|
|
[QC-MIL-001]: ../../../framework/qc/qc-milestones-gateways.md
|
|
[QC-LANG-001]: ../../../framework/qc/qc-language-domain.md
|
|
[BC-001]: ../../business-case.md
|
|
[DICT-001]: ../../dictionary.md
|
|
[PP-001]: ../../project-plan.md
|
|
[f13d004]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/021-snake-game/commit/f13d004447ceb631cb22c058d68a21b721a3f04c
|