Tirsvad-Udemy-100-days-of-code/018-hirst-painting
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Sync MIL-003 to Gitea: unique task 6 title, delta confirmation, milestone link

Browse Source 
The MIL-003 milestone (id 74) and its issues #22 to #27 are created on Gitea.

Creating them exposed a collision: task 6 of MIL-003 had the same title as
task 6 of MIL-001, and sync-project.sh matches issues by title, so it
overwrote the closed MIL-001 issue #6 (milestone and a Phase line). Issue #6
was restored, and MIL-003 task 6 is renamed "Review the visible-colours code
against qc-programming-python", which is issue #27. No other task title is
shared between the milestone documents.

- MIL-003: rename task 6 (new Version History row, accepted by S01).
- RC-008: add the delta confirmation for the rename; no criterion result
  changes (new row, accepted by S01).
- PP-001: link the MIL-003 gateway to its Milestone (a link update, no new
  Version History row).
This commit is contained in:
Tirsvad
2026-10-08 01:29:27 +08:00
parent d376875d72
commit 22b7329b47
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/milestones/mil-003-visible-colours.md
+3 -2
View File
@@ -11,7 +11,8 @@
## Version History
| Date | Status | Author | Reviewer | Change | Commit |
| --- | --- | --- | --- | --- | --- |
| 2026-10-08 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [188b2e9] |
| 2026-10-08 | Deprecated | Jens Tirsvad Nielsen | S01 | Initial version | [188b2e9] |
| 2026-10-08 | Accepted | Jens Tirsvad Nielsen | S01 | Renamed task 6 so that its issue title is unique across the milestones (issue #27) | pending |
---
@@ -78,7 +79,7 @@ Tasks column "Needs its own Use Case/User Story?" says `No` throughout.
| 3 | Add tests for the measure and the filter | Add tests under `tests/` with known values (white 1.0, black 21.0, a mid grey) and with the boundary: a colour just below 2.0 is dropped and one just above is kept. They pin the limit before the real image is involved, as the white-shade tests do for 240. | No | |
| 4 | Apply the filter when the palette is extracted | Make `extract_palette` apply the faint-colour filter after the white-shade filter, update its tests, and add one that checks the palette of the reference image: no colour below 2.0 and at least 2 colours. Print the palette with each contrast; the measurement on 2026-10-08 predicts 22 colours. | No | |
| 5 | Check the painting again with a real run | Run `main` on a real window, time it and capture the picture: 100 dots in 10 rows of 10, no trail, no turtle cursor, the window open until a click, and every dot clearly visible on the white background. This rechecks SC1 to SC8 together. | No | |
| 6 | Review the phase code against qc-programming-python | Check the code of this phase against `framework/qc/qc-programming-python.md` and record the result as an `RC-*`; a `Go` verdict is Go criterion 5 (SC7). | No | |
| 6 | Review the visible-colours code against qc-programming-python | Check the code of this phase against `framework/qc/qc-programming-python.md` and record the result as an `RC-*`; a `Go` verdict is Go criterion 5 (SC7). | No | |
---