diff --git a/docs/milestones/mil-003-visible-colours.md b/docs/milestones/mil-003-visible-colours.md index e9b3dad..7976c4b 100644 --- a/docs/milestones/mil-003-visible-colours.md +++ b/docs/milestones/mil-003-visible-colours.md @@ -11,7 +11,8 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-08 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | [188b2e9] | +| 2026-10-08 | Deprecated | Jens Tirsvad Nielsen | S01 | Initial version | [188b2e9] | +| 2026-10-08 | Accepted | Jens Tirsvad Nielsen | S01 | Renamed task 6 so that its issue title is unique across the milestones (issue #27) | pending | --- @@ -78,7 +79,7 @@ Tasks column "Needs its own Use Case/User Story?" says `No` throughout. | 3 | Add tests for the measure and the filter | Add tests under `tests/` with known values (white 1.0, black 21.0, a mid grey) and with the boundary: a colour just below 2.0 is dropped and one just above is kept. They pin the limit before the real image is involved, as the white-shade tests do for 240. | No | | | 4 | Apply the filter when the palette is extracted | Make `extract_palette` apply the faint-colour filter after the white-shade filter, update its tests, and add one that checks the palette of the reference image: no colour below 2.0 and at least 2 colours. Print the palette with each contrast; the measurement on 2026-10-08 predicts 22 colours. | No | | | 5 | Check the painting again with a real run | Run `main` on a real window, time it and capture the picture: 100 dots in 10 rows of 10, no trail, no turtle cursor, the window open until a click, and every dot clearly visible on the white background. This rechecks SC1 to SC8 together. | No | | -| 6 | Review the phase code against qc-programming-python | Check the code of this phase against `framework/qc/qc-programming-python.md` and record the result as an `RC-*`; a `Go` verdict is Go criterion 5 (SC7). | No | | +| 6 | Review the visible-colours code against qc-programming-python | Check the code of this phase against `framework/qc/qc-programming-python.md` and record the result as an `RC-*`; a `Go` verdict is Go criterion 5 (SC7). | No | | --- diff --git a/docs/project-plan.md b/docs/project-plan.md index 1ff7d09..882a322 100644 --- a/docs/project-plan.md +++ b/docs/project-plan.md @@ -38,7 +38,7 @@ own milestone document, and each gateway ends with a Go/No-Go decision by S01. | --- | --- | --- | --- | --- | --- | --- | --- | | Colour palette | [MIL-001] | 2026-10-07 to 2026-10-09 | 2026-10-09 | S01 | none | Palette function that returns the reference image's colours without white shades | [MIL-001 milestone] | | Spot painting | [MIL-002] | 2026-10-10 to 2026-10-14 | 2026-10-14 | S01 | none | Program that draws the 10 by 10 painting and meets SC1 to SC7 of [BC-001] | [MIL-002 milestone] | -| Visible colours | [MIL-003] | 2026-10-08 to 2026-10-10 | 2026-10-10 | S01 | none | Palette without faint colours: every colour has a contrast of 2.0 or more with white (O6, SC8 of [BC-001]) | | +| Visible colours | [MIL-003] | 2026-10-08 to 2026-10-10 | 2026-10-10 | S01 | none | Palette without faint colours: every colour has a contrast of 2.0 or more with white (O6, SC8 of [BC-001]) | [MIL-003 milestone] | ```plantuml @startgantt @@ -113,6 +113,7 @@ Both decisions came before the planned dates because every Go criterion was alre [MIL-003]: ./milestones/mil-003-visible-colours.md [MIL-001 milestone]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-hirst-painting/milestone/68 [MIL-002 milestone]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-hirst-painting/milestone/69 +[MIL-003 milestone]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-hirst-painting/milestone/74 [PR 14]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-hirst-painting/pulls/14 [PR 16]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-hirst-painting/pulls/16 [a6b17d3]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-hirst-painting/commit/a6b17d30bc0778b7f80c57bfd22a505df5fe9ee1 diff --git a/docs/sqa/reviews/rc-008-milestone-mil-003.md b/docs/sqa/reviews/rc-008-milestone-mil-003.md index 9172b3f..caa2a00 100644 --- a/docs/sqa/reviews/rc-008-milestone-mil-003.md +++ b/docs/sqa/reviews/rc-008-milestone-mil-003.md @@ -9,7 +9,8 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-08 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version (draft prepared by the assistant for S01 to confirm)
Terms confirmed by S01, verdict `Go` | [188b2e9] | +| 2026-10-08 | Deprecated | Jens Tirsvad Nielsen | S01 | Initial version (draft prepared by the assistant for S01 to confirm)
Terms confirmed by S01, verdict `Go` | [188b2e9] | +| 2026-10-08 | Accepted | Jens Tirsvad Nielsen | S01 | Added the delta confirmation for the rename of task 6 of MIL-003 | pending | --- @@ -25,6 +26,8 @@ every criterion and recorded what it found; S01 confirmed the open point on 2026-10-08 and the verdict is `Go`. +**Delta confirmation, 2026-10-08:** after the review, task 6 of [MIL-003] was renamed from "Review the phase code against qc-programming-python" to "Review the visible-colours code against qc-programming-python". The old title was the same as the title of task 6 of MIL-001, and `sync-project.sh` matches issues by title, so creating the issues overwrote the closed MIL-001 issue #6; it was restored, and the renamed task became issue #27. No criterion result below changes: the summary, the deliverable, the criteria, the traceability, the ownership and the date are untouched, and the new title uses the project's own term (*visible colours*) from [MIL-003]. + ## Checklist Results | # | Criterion | Status | Evidence/Notes |