Tirsvad
b3f006f7a4
Verified on 2026-10-10 with throwaway branches (deleted afterwards): workflow_call and uses run from the same repository, another repository of the organisation and a repository of another organisation, so MIL-003 needs no copied-template fallback. Not tested: a private provider, secrets passed to a called workflow, and a tag reference. Review it (RC-033) and update TM-001. Task: MIL-003#1
46 lines
1.7 KiB
Markdown
46 lines
1.7 KiB
Markdown
# Review Record: MIL-003 (reusable workflow support verified)
|
|
|
|
## Metadata
|
|
| Key | Value |
|
|
| --- | --- |
|
|
| ID | RC-033 |
|
|
| CrossReference | [MIL-003], [QC-MIL-001] |
|
|
|
|
## Version History
|
|
| Date | Status | Author | Reviewer | Change | Commit |
|
|
| --- | --- | --- | --- | --- | --- |
|
|
| 2026-10-10 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | pending |
|
|
|
|
---
|
|
|
|
## Artifact Under Review
|
|
|
|
- Instance reviewed: [MIL-003]
|
|
- Checklist used: [QC-MIL-001]
|
|
|
|
## Checklist Results
|
|
|
|
| # | Criterion | Status | Evidence/Notes |
|
|
| --- | --- | --- | --- |
|
|
| 1 | A concrete deliverable is defined for every gate | Pass | Unchanged. |
|
|
| 2 | Explicit Go/No-Go criteria are stated for each gate | Pass | Unchanged; criterion 1 (reusable workflows verified and recorded) is now evidenced by the Verification results. |
|
|
| 3 | Dependencies on other milestones are explicitly mapped | Pass | Unchanged. |
|
|
| 4 | Each milestone is traceable to a Business Case objective or KPI | Pass | Unchanged. |
|
|
| 5 | Milestone owner and approving reviewer are identified | Pass | Unchanged. |
|
|
| 6 | Milestone has a defined target date consistent with project constraints | Pass | Unchanged. |
|
|
|
|
## Overall Verdict
|
|
|
|
Go - all six criteria pass; the reviewed change records the result of task 1 and its limits (private provider, secrets, tag references not tested). S01 gave the Go in chat on 2026-10-10, standing in for the other reviewers as ADR-0002 records; there is no independent reader.
|
|
|
|
## Action Items
|
|
|
|
| Action | Owner | Due |
|
|
| --- | --- | --- |
|
|
| Test a private provider repository, `secrets: inherit` and a tag reference before MIL-004 relies on them | S05 | 2026-11-28 |
|
|
|
|
---
|
|
|
|
[MIL-003]: ../../milestones/mil-003-quality-checks.md
|
|
[QC-MIL-001]: ../../../framework/qc/qc-milestones-gateways.md
|