Fix the review findings of the VPN actions, lint them in CI, record MIL-012 results #195

Merged

Tirsvad merged 5 commits from mil-012-review-fixes-and-docs into main 2026-10-19 06:08:12 +02:00

Conversation 0 Commits 5 Files Changed 17

+548 -64

5 Commits

Author	SHA1	Message	Date
Tirsvad	b75ed03d3f	Resolve pending commit links for MIL-012 results	2026-10-19 12:01:24 +08:00
Tirsvad	3325bea772	Record the MIL-012 results of tasks 1 and 6, ADR-0011 and RC-082 ... Task 1: both forms of uses: resolve a subfolder action at main. Adds ADR-0011 (Proposed, not yet reviewed), the review record RC-082 for the milestone results, and the traceability rows. Refs #182 Refs #190	2026-10-19 12:01:18 +08:00
Tirsvad	a91e0233c1	Lint the shell scripts of the actions in the validation run ... tools/lint-action-scripts.sh runs shellcheck and shfmt on actions/**/*.sh with pinned tools; validate-workflows.yml runs it, and .editorconfig sets the shell format. The tests show a shellcheck problem and a badly formatted script fail. Refs #187 Task: MIL-012#6	2026-10-19 12:01:11 +08:00
Tirsvad	7a30560a74	Fix the review findings in connect-tailscale ... tailscaled is waited for before tailscale up, a tailscaled that already runs on the runner is not taken over and down leaves a daemon it did not start, sudo is used only when the job is not root, an exact version is required to install (with an optional sha256 of the archive), and the guide states when the node is ephemeral and calls @main until the release. Refs #185 Task: MIL-012#4	2026-10-19 12:01:06 +08:00
Tirsvad	9e1cfa5fa8	Fix the review findings in connect-wireguard ... The wireguard-go choice now survives sudo (it is passed through env), sudo is used only when the job is not root, a configuration field with a line break is refused, only the key values of a full configuration are masked, the key file is removed when wg-quick fails, and the guide calls @main until the release. Refs #184 Task: MIL-012#3	2026-10-19 12:01:00 +08:00