MIL-007 task 7: adoption in two throwaway repositories, seeded failures verified

Results and review (RC-059, autonomous, AI as stand-in for S01) added to the milestone. The guides and their wiki pages now say that clang-tidy and dotnet print absolute paths in the workspace of the runner. Task: MIL-007#7 Closes #101
2026-10-13 12:26:56 +08:00
parent de5d330445
commit 2481c26d80
13 changed files with 106 additions and 16 deletions
@@ -0,0 +1,50 @@
+# Review Record: MIL-007 (task 7 results)
+
+## Metadata
+| Key | Value |
+| --- | --- |
+| ID | RC-059 |
+| CrossReference | [MIL-007], [QC-MIL-001] |
+
+## Version History
+| Date | Status | Author | Reviewer | Change | Commit |
+| --- | --- | --- | --- | --- | --- |
+| 2026-10-13 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version | pending |
+
+---
+
+## Artifact Under Review
+
+- Instance reviewed: [MIL-007] with the verification results of task 7 (adoption in two throwaway repositories, seeded failures)
+- Checklist used: [QC-MIL-001]
+- Scope: delta re-review of the added results and of Go/No-Go criteria 3 and 4; the earlier record is [RC-055]
+- Language and domain: n/a (technical type)
+- Language reviewer: none
+- Mode: autonomous, not independent (the reviewer is `AI as stand-in for S01`; the user chose the throwaway repositories in chat on 2026-10-13)
+
+## Checklist Results
+
+| # | Criterion | Status | Evidence/Notes |
+| --- | --- | --- | --- |
+| 1 | A concrete deliverable is defined for every gate | Pass | Unchanged. |
+| 2 | Explicit Go/No-Go criteria are stated for each gate | Pass | Criterion 3 (tool, file and line in the log) and 4 (status on pull requests) are met for both workflows by runs 906 and the C# run of the same pull request, as the verification results table lists. |
+| 3 | Dependencies on other milestones are explicitly mapped | Pass | Unchanged: MIL-003 and MIL-004. |
+| 4 | Each milestone is traceable to a Business Case objective or KPI | Pass | Unchanged: O4, US-001.09, .10, .16, .17. |
+| 5 | Milestone owner and approving reviewer are identified | Pass | Owner S05, approving reviewer S01. |
+| 6 | Milestone has a defined target date consistent with project constraints | Pass | 2027-01-16, unchanged. |
+
+## Overall Verdict
+
+Go - all six criteria pass. Criteria 3 and 4 of the milestone are verified on throwaway repositories only; a real project with a compile database or many packages is still open and is said so in the results. S01 is stood in for by the AI as the user chose autonomous mode; there is no independent reader, and the decision stays open to challenge.
+
+## Action Items
+
+| Action | Owner | Due |
+| --- | --- | --- |
+| Decide whether to delete `TirSystem/qc-adoption-cpp` and `TirSystem/qc-adoption-csharp`, and adopt the workflows in a real C++ and C# project | S05 | before the milestone closes |
+
+---
+
+[MIL-007]: ../../milestones/mil-007-cpp-csharp-quality-checks.md
+[RC-055]: ./rc-055-mil-007-amendment.md
+[QC-MIL-001]: ../../../framework/qc/qc-milestones-gateways.md