Adopt each workflow in one other repository #101

Open
opened 2026-10-11 06:21:55 +02:00 by Tirsvad · 1 comment
Owner

Onboard a real C++ project and a real C# project, or a throwaway repository when none exists, and fix the gaps in the guides that appear. Verify a seeded failure.

Phase: MIL-007

Onboard a real C++ project and a real C# project, or a throwaway repository when none exists, and fix the gaps in the guides that appear. Verify a seeded failure. Phase: MIL-007
Tirsvad added this to the MIL-007: Quality checks for C++ and C# milestone 2026-10-11 06:21:55 +02:00
Author
Owner

Adoption trial, first part (2026-10-11). Throwaway branch of this repository, deleted afterwards; both workflows called by branch with tools-ref set to the same branch; clean and seeded samples (runs 757, 759, 761).

Sample Last run (761) Log
C++ clean success PASS clang-format, PASS clang-tidy (C++)
C++ seeded failure main.cpp:2:12: error: code should be clang-formatted; main.cpp:2:40: error: Dereference of null pointer ... [clang-analyzer-core.NullDereference,-warnings-as-errors]
C# clean success SDK 10.0.401 installed; PASS dotnet format --verify-no-changes; PASS dotnet build -warnaserror
C# seeded failure Program.cs(2,19): error CS8602; FAIL dotnet build -warnaserror

Criterion 3 of MIL-007 (a failing check shows tool, file and line) is met for both. The runs found three defects that the stub-tool tests could not (clang-tidy without .clang-tidy runs no check; compile-commands-dir was resolved from the working directory; clang-tidy exits 0 on a warning), all fixed on the branch of PR 110.

Not done, so this issue stays open: criterion 4 needs one other repository with C++ code and one with C# code that call the workflows and show the status on a pull request. No repository of the four organizations has C, C++ or C# code, so this was a trial on samples. Options: name a repository, or create two small throwaway repositories for the purpose, or amend the criterion.

Adoption trial, first part (2026-10-11). Throwaway branch of this repository, deleted afterwards; both workflows called by branch with `tools-ref` set to the same branch; clean and seeded samples (runs 757, 759, 761). | Sample | Last run (761) | Log | | --- | --- | --- | | C++ clean | success | `PASS clang-format`, `PASS clang-tidy (C++)` | | C++ seeded | failure | `main.cpp:2:12: error: code should be clang-formatted`; `main.cpp:2:40: error: Dereference of null pointer ... [clang-analyzer-core.NullDereference,-warnings-as-errors]` | | C# clean | success | SDK 10.0.401 installed; `PASS dotnet format --verify-no-changes`; `PASS dotnet build -warnaserror` | | C# seeded | failure | `Program.cs(2,19): error CS8602`; `FAIL dotnet build -warnaserror` | Criterion 3 of MIL-007 (a failing check shows tool, file and line) is met for both. The runs found three defects that the stub-tool tests could not (clang-tidy without `.clang-tidy` runs no check; `compile-commands-dir` was resolved from the working directory; clang-tidy exits 0 on a warning), all fixed on the branch of PR 110. **Not done, so this issue stays open:** criterion 4 needs one other repository with C++ code and one with C# code that call the workflows and show the status on a pull request. No repository of the four organizations has C, C++ or C# code, so this was a trial on samples. Options: name a repository, or create two small throwaway repositories for the purpose, or amend the criterion.
Sign in to join this conversation.