Records the results of the trial of the English-comments check (MIL-013 task 8, #204) and of the merged work (tasks 1 to 7, 10, 13) in the milestone, with the review record RC-085.
What this changes
## Verification results in MIL-013: the runs on the instance (433, 435, 437, 440, 443, 445, 447), the three defects the trial found, the search of the job logs for credentials, and what the trial did not show.
RC-085 (Go): a delta review of the milestone and a check of every claim in the results against the API and the logs. The milestone is Accepted again.
The traceability rows for RC-085 and ADR-0012.
The three defects (fixed in pull request 212, open)
A Danish comment line directly under an English one was missed.
In a called workflow gitea.event_name is workflow_call, so the step that comments on the pull request was skipped.
The link in the comment used the run number instead of the run id.
What this does not do
It changes no code. ADR-0012 stays Proposed and has no review record. Tasks 9, 11, 12 and 14 are open, and the corrected workflow has not yet been called at @main (it needs pull request 212 merged). The review is supervised and not independent: the author stood in for S01.
Issues
No issue closed: the trial is done but depends on pull request 212, and the milestone has open tasks.
Commits carry Task: MIL-013#8 and #14 trailers. Not merged by the author.
Records the results of the trial of the English-comments check (MIL-013 task 8, #204) and of the merged work (tasks 1 to 7, 10, 13) in the milestone, with the review record RC-085.
## What this changes
- `## Verification results` in MIL-013: the runs on the instance (433, 435, 437, 440, 443, 445, 447), the three defects the trial found, the search of the job logs for credentials, and what the trial did not show.
- RC-085 (Go): a delta review of the milestone and a check of every claim in the results against the API and the logs. The milestone is `Accepted` again.
- The traceability rows for RC-085 and ADR-0012.
## The three defects (fixed in pull request 212, open)
1. A Danish comment line directly under an English one was missed.
2. In a called workflow `gitea.event_name` is `workflow_call`, so the step that comments on the pull request was skipped.
3. The link in the comment used the run number instead of the run id.
## What this does not do
It changes no code. ADR-0012 stays `Proposed` and has no review record. Tasks 9, 11, 12 and 14 are open, and the corrected workflow has not yet been called at `@main` (it needs pull request 212 merged). The review is supervised and not independent: the author stood in for S01.
## Issues
No issue closed: the trial is done but depends on pull request 212, and the milestone has open tasks.
Refs #204
Refs #210
Commits carry `Task: MIL-013#8` and `#14` trailers. Not merged by the author.
Adds the verification results of tasks 1 to 8, 10 and 13 to MIL-013: the three
defects the trial found (a Danish line beside an English one, the skipped
author step, the run link), the runs, and the search of the logs for
credentials. RC-085 reviews the results; the milestone is Accepted again.
Refs #204
Refs #210
Task: MIL-013#8
Task: MIL-013#14
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Records the results of the trial of the English-comments check (MIL-013 task 8, #204) and of the merged work (tasks 1 to 7, 10, 13) in the milestone, with the review record RC-085.
What this changes
## Verification resultsin MIL-013: the runs on the instance (433, 435, 437, 440, 443, 445, 447), the three defects the trial found, the search of the job logs for credentials, and what the trial did not show.Acceptedagain.The three defects (fixed in pull request 212, open)
gitea.event_nameisworkflow_call, so the step that comments on the pull request was skipped.What this does not do
It changes no code. ADR-0012 stays
Proposedand has no review record. Tasks 9, 11, 12 and 14 are open, and the corrected workflow has not yet been called at@main(it needs pull request 212 merged). The review is supervised and not independent: the author stood in for S01.Issues
No issue closed: the trial is done but depends on pull request 212, and the milestone has open tasks.
Refs #204
Refs #210
Commits carry
Task: MIL-013#8and#14trailers. Not merged by the author.