Files
014-higher_lower/docs/sqa/reviews/rc-005-mil-002.md
T
Tirsvad ee58fcdc1c Add game data, art, constants and game logic
Add the assignment data set (50 accounts), the logo and vs art, the
constants module, and the pure functions get_random_account,
pick_pair, format_data and check_answer, all with Doxygen comments.
pick_pair never returns the same account twice; check_answer accepts
either choice on a tie. Cover them with pytest tests (22 passing).

The art is built from concatenated raw lines so the backslashes survive
and Doxygen does not read the backticks as markup.

Accept MIL-002 after review RC-005 and add it to the Traceability
Matrix.

Task: MIL-002#1
Task: MIL-002#2
Task: MIL-002#3
Task: MIL-002#4
Task: MIL-002#5
Task: MIL-002#6
Closes #6
Closes #7
Closes #8
Closes #9
Closes #10
Closes #11
2026-10-04 23:34:48 +08:00

1.8 KiB

SQA Review Record: MIL-002 Game logic

Metadata

Key Value
ID RC-005
CrossReference MIL-002, QC-MIL-001

Version History

Date Status Author Reviewer Change Commit
2026-10-04 Accepted Jens Tirsvad Nielsen S01 Initial version pending

Artifact Under Review

Checklist Results

# Criterion Status Evidence/Notes
1 A concrete deliverable is defined for every gate Pass Data and art modules, constants, four named functions, Doxygen comments, pytest tests.
2 Explicit Go/No-Go criteria are stated for each gate Pass Six objectively checkable criteria.
3 Dependencies on other milestones are explicitly mapped (Optional) Pass Depends on MIL-001, with the reason.
4 Each milestone is traceable to a Business Case objective or KPI Pass O1, O2, O3.
5 Milestone owner and approving reviewer are identified Pass S01 and S01.
6 Milestone has a target date consistent with project constraints Pass 2026-10-09, inside the 2026-10-14 constraint in BC-001.

Overall Verdict

Go — all criteria pass. Code under src/ and tests/ for MIL-002 may start once the MIL-001 deliverables exist (its dependency). MIL-003 and MIL-004 stay Proposed. Reviewer and author are both S01: the project has a single participant, so the framework's author/reviewer separation cannot be met. S01 accepted this deviation when requesting acceptance (2026-10-04).

Action Items

Action Owner Due
Deliver MIL-001 (issues #1-#4) before starting MIL-002 tasks S01 2026-10-06