# SQA Review Record

## Metadata
| Key | Value |
| --- | --- |
| ID | RC-006 |
| CrossReference | [ADR-0001], [QC-ADR-001] |

## Version History
| Date | Status | Author | Reviewer | Change | Commit |
| --- | --- | --- | --- | --- | --- |
| 2026-11-06 | Proposed | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version: review of ADR-0001, two rounds | [a07d05b] |

---

## Artifact Under Review

- Instance reviewed: [ADR-0001]
- Checklist used: [QC-ADR-001] (a technical type: no QC-LANG-001 table)
- Scope: full review. Round 1 found two defects (criterion 10 and the shared rationale for criterion 4); they were fixed in the ADR and the criteria re-checked in round 2, which this record shows.
- Language and domain: n/a (technical type)
- Language reviewer: none
- Mode: autonomous, not independent (the reviewer is `AI as stand-in for S01`; S01 is also the author and Product Owner)

## Checklist Results

| # | Criterion | Status | Evidence/Notes |
| --- | --- | --- | --- |
| 1 | The ID (`ADR-NNNN`, 4-digit) matches the filename number and is unique and sequential | Pass | ID `ADR-0001`, file `adr-0001-...`; the only ADR; registry next version is 0002 |
| 2 | Context states the problem, the forces (cost, risk, constraints) and the options evaluated | Pass | Problem: stories/use cases and code layout for a one-function exercise; Forces paragraph (date 2026-11-09, S02 and S03 wants, layers hiding the three functions); options (a) and (b) for both decisions |
| 3 | At least two options were considered, or the absence of alternatives is justified | Pass | Two options for each of the two decisions |
| 4 | Decision is stated in one or two unhedged sentences and matches one of the evaluated options | Pass | Two sentences, no hedging; they match option (b) of each decision. Round 1: two decisions share one driver (proportion to the exercise), now stated in Context, so they are not unrelated |
| 5 | Consequences list both Positive and Negative outcomes | Pass | Both lists present; negatives: does not scale, no story-level traceability |
| 6 | Quality-attribute impacts (performance, security, portability, etc.) are named where the decision affects them | Pass | Maintainability/scalability limit named as negative; no runtime dependencies named as positive; performance and security are not affected |
| 7 | Affected Artifacts are listed as links, and each is also in CrossReference | Pass | BC-001 and PP-001 are linked and both in CrossReference; PP-001 "Stories" column does say "none" and point to ADR-0001 |
| 8 | Status changes are recorded as new Version History rows with a Change summary and Commit link; retained rows are never rewritten | Pass | Acceptance is a new row, the earlier row only moves to Deprecated as the RC process says; Commit is `pending` until the commit exists (resolved by `resolve-pending-commits.sh`) |
| 9 | A superseded or deprecated ADR names its successor, and the successor links back | N-A | ADR-0001 is not superseded; the Deprecated row is a version row, not the ADR |
| 10 | Written in business or technical language of the domain, with no unexplained abbreviations | Pass | Round 1 Fail: S01 to S03 were bare IDs. Fixed: S01, S02 and S03 are now glossed in Context |
| 11 | Status is one of `Proposed`, `Accepted`, `Rejected`, `Deprecated` or `Superseded by ADR-NNNN`, and every Version History row uses only these | Pass | Rows use `Deprecated` and `Accepted` only |

## Overall Verdict

Go. Every Mandatory criterion passes after the two round 1 fixes; criterion 9 is N-A with a reason. Not independent: the author and the stand-in reviewer are the same party.

## Action Items

| Action | Owner | Due |
| --- | --- | --- |
| Resolve the pending commit links after the commit | S01 | 2026-11-09 |

---

[ADR-0001]: ../../adr/adr-0001-skip-stories-plain-package.md
[QC-ADR-001]: ../../../framework/qc/artifacts/qc-adr.md
[a07d05b]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/054-speed-calc-decorator/commit/a07d05b385e6b831b90731aefe08f078ebb951ca