Compare commits
3
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f161859225 | ||
|
|
5fe4ef0367 | ||
|
|
83b07742a8 |
@@ -17,3 +17,6 @@ tmp/
|
||||
|
||||
# AI prompt log (public repository)
|
||||
/docs/ai-prompts/
|
||||
|
||||
# Local preview configuration (a throwaway static server for screenshots)
|
||||
/.claude/launch.json
|
||||
|
||||
@@ -15,7 +15,7 @@ document of a type. `Primary File` may contain a glob (e.g.
|
||||
| SA | Stakeholder Analysis | docs/stakeholder-analysis.md | 002 |
|
||||
| PP | Project Plan | docs/project-plan.md | 002 |
|
||||
| MIL | Milestone / Gateway | docs/milestones/mil-*.md | 004 |
|
||||
| RC | Review Record | docs/sqa/reviews/rc-*.md | 006 |
|
||||
| RC | Review Record | docs/sqa/reviews/rc-*.md | 007 |
|
||||
| TM | Traceability Matrix | docs/sqa/traceability-matrix.md | 002 |
|
||||
|
||||
## Languages
|
||||
|
||||
@@ -0,0 +1,48 @@
|
||||
# SQA Review Record
|
||||
|
||||
## Metadata
|
||||
| Key | Value |
|
||||
| --- | --- |
|
||||
| ID | RC-006 |
|
||||
| CrossReference | [MIL-002] |
|
||||
|
||||
## Version History
|
||||
| Date | Status | Author | Reviewer | Change | Commit |
|
||||
| --- | --- | --- | --- | --- | --- |
|
||||
| 2026-10-24 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version | [5fe4ef0] |
|
||||
|
||||
---
|
||||
|
||||
## Artifact Under Review
|
||||
|
||||
- Instance reviewed: [MIL-002] deliverable: `src/index.html`, `src/styles.css`, `tests/manual-checklist.md`
|
||||
- Checklist used: the Go / No-Go criteria of [MIL-002]. No QC checklist exists for HTML source in the framework (`framework/qc/code/` has none), so the milestone criteria stand in as the checklist.
|
||||
- Scope: full review
|
||||
- Language and domain: n/a (a deliverable, not a document of a PO-language type)
|
||||
- Language reviewer: none
|
||||
- Mode: autonomous, not independent (the reviewer is `AI as stand-in for S01`)
|
||||
|
||||
## Checklist Results
|
||||
|
||||
| # | Criterion | Status | Evidence/Notes |
|
||||
| --- | --- | --- | --- |
|
||||
| 1 | One h1 "The Best Movies According to Tirsvad", one h2, one hr | Pass | Read from the DOM in the browser pane: 1 h1, 1 h2 "My top 3 movies of all-time.", 1 hr. |
|
||||
| 2 | Three h3 in order 13 element, 5th element, Drive, each directly followed by a p | Pass | DOM read: the next sibling of each h3 is a P. The wording is S01's supplied HTML, unchanged. |
|
||||
| 3 | HTML5 with `lang`, `charset` and `viewport`, no external request | Pass | `<!DOCTYPE html>`, `lang="en"`, charset and viewport meta present; the resource list holds only `styles.css`. No W3C validator was run (no network tool for it). |
|
||||
| 4 | Every item of `tests/manual-checklist.md` marked pass, checked in the browser pane | Pass | Eight items run on 2026-10-24, including a 375 px wide viewport without sideways scroll. |
|
||||
| 5 | Reviewed against the assignment and the checklist | Pass | The assignment asks for h1, h2, hr and at least three h3 each with a p; all are present. |
|
||||
|
||||
## Overall Verdict
|
||||
|
||||
Go — all five criteria pass. This is a stand-in review, not an independent one, and S01 can challenge it in the final summary.
|
||||
|
||||
## Action Items
|
||||
|
||||
| Action | Owner | Due |
|
||||
| --- | --- | --- |
|
||||
| None | S01 | n/a |
|
||||
|
||||
---
|
||||
|
||||
[MIL-002]: ../../milestones/mil-002-movie-page.md
|
||||
[5fe4ef0]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/041-web-movie-ranking/commit/5fe4ef03673e70026a0667a2585f2d9decb6a2c2
|
||||
@@ -9,7 +9,8 @@
|
||||
## Version History
|
||||
| Date | Status | Author | Reviewer | Change | Commit |
|
||||
| --- | --- | --- | --- | --- | --- |
|
||||
| 2026-10-24 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version | [e8d24b2] |
|
||||
| 2026-10-24 | Deprecated | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version | [e8d24b2] |
|
||||
| 2026-10-24 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Added RC-006 for the MIL-002 deliverable | [5fe4ef0] |
|
||||
|
||||
---
|
||||
|
||||
@@ -27,7 +28,7 @@ updated whenever an artifact instance is created or reviewed.
|
||||
| [SA-001] | SA | en | it | [BC-001] | [PP-001] | [RC-002] |
|
||||
| [PP-001] | PP | en | it | [BC-001], [SA-001] | [MIL-001], [MIL-002], [MIL-003] | - |
|
||||
| [MIL-001] | MIL | en | it | [BC-001], [PP-001] | [MIL-002] | [RC-003] |
|
||||
| [MIL-002] | MIL | en | it | [BC-001], [PP-001] | [MIL-003] | [RC-004] |
|
||||
| [MIL-002] | MIL | en | it | [BC-001], [PP-001] | [MIL-003] | [RC-004], [RC-006] |
|
||||
| [MIL-003] | MIL | en | it | [BC-001], [PP-001] | - | [RC-005] |
|
||||
|
||||
## Coverage Notes
|
||||
@@ -47,4 +48,6 @@ No use case, domain model or design artifact exists: the project is too small fo
|
||||
[RC-003]: ./reviews/rc-003-mil-001-foundation.md
|
||||
[RC-004]: ./reviews/rc-004-mil-002-movie-page.md
|
||||
[RC-005]: ./reviews/rc-005-mil-003-documentation.md
|
||||
[RC-006]: ./reviews/rc-006-movie-page.md
|
||||
[e8d24b2]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/041-web-movie-ranking/commit/e8d24b2d32ce1ef8276123b0efa05b8a15e27d52
|
||||
[5fe4ef0]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/041-web-movie-ranking/commit/5fe4ef03673e70026a0667a2585f2d9decb6a2c2
|
||||
|
||||
@@ -0,0 +1,22 @@
|
||||
<!DOCTYPE html>
|
||||
<html lang="en">
|
||||
<head>
|
||||
<meta charset="utf-8">
|
||||
<meta name="viewport" content="width=device-width, initial-scale=1">
|
||||
<title>The Best Movies According to Tirsvad</title>
|
||||
<link rel="stylesheet" href="styles.css">
|
||||
</head>
|
||||
<body>
|
||||
<main>
|
||||
<h1>The Best Movies According to Tirsvad</h1>
|
||||
<h2>My top 3 movies of all-time.</h2>
|
||||
<hr>
|
||||
<h3>13 element</h3>
|
||||
<p>This is my favourite anime. I love the beautiful images.</p>
|
||||
<h3>5th element</h3>
|
||||
<p>Really cool sci-fi movie.</p>
|
||||
<h3>Drive</h3>
|
||||
<p>Super beautiful film. Really artistic.</p>
|
||||
</main>
|
||||
</body>
|
||||
</html>
|
||||
@@ -0,0 +1,33 @@
|
||||
/* Readable typography for the Favorite Movie page. No external requests. */
|
||||
:root {
|
||||
color-scheme: light dark;
|
||||
}
|
||||
|
||||
body {
|
||||
margin: 0;
|
||||
font-family: system-ui, -apple-system, "Segoe UI", Roboto, sans-serif;
|
||||
line-height: 1.6;
|
||||
}
|
||||
|
||||
main {
|
||||
max-width: 40rem;
|
||||
margin: 0 auto;
|
||||
padding: 2rem 1rem;
|
||||
}
|
||||
|
||||
h1 {
|
||||
margin-bottom: 0.25rem;
|
||||
}
|
||||
|
||||
h2 {
|
||||
margin-top: 0;
|
||||
font-weight: 400;
|
||||
}
|
||||
|
||||
h3 {
|
||||
margin-bottom: 0.25rem;
|
||||
}
|
||||
|
||||
p {
|
||||
margin-top: 0;
|
||||
}
|
||||
@@ -0,0 +1,17 @@
|
||||
# Manual test checklist: Favorite Movie page
|
||||
|
||||
Open `src/index.html` in a browser (see the README). Mark each item `Pass` or
|
||||
`Fail` and note the date and browser.
|
||||
|
||||
Last run: 2026-10-24, built-in browser pane (Chromium), page served from a throwaway local static server so that `styles.css` loads (the pane shows `file://` pages as a static snapshot without the stylesheet). Items 1 to 5 and 8 were read from the DOM; item 6 from the resource list; item 7 at a 375 px wide viewport (scroll width equals client width).
|
||||
|
||||
| # | Check | Expected | Result |
|
||||
| --- | --- | --- | --- |
|
||||
| 1 | Exactly one `h1` | Text is "The Best Movies According to Tirsvad" | Pass |
|
||||
| 2 | Exactly one `h2` | Text is "My top 3 movies of all-time." | Pass |
|
||||
| 3 | Exactly one `hr` | A horizontal rule sits between the subtitle and the movies | Pass |
|
||||
| 4 | Three `h3` in order | 13 element, 5th element, Drive | Pass |
|
||||
| 5 | Each `h3` is directly followed by a `p` | Three paragraphs with the reasons | Pass |
|
||||
| 6 | No external request | The network log shows only `index.html` and `styles.css` | Pass |
|
||||
| 7 | Narrow window (375 px wide) | Text wraps and nothing scrolls sideways | Pass |
|
||||
| 8 | Page title | The tab shows "The Best Movies According to Tirsvad" | Pass |
|
||||
Reference in New Issue
Block a user