|
|
|
@@ -0,0 +1,63 @@
|
|
|
|
|
# SQA Review Record
|
|
|
|
|
|
|
|
|
|
## Metadata
|
|
|
|
|
| Key | Value |
|
|
|
|
|
| --- | --- |
|
|
|
|
|
| ID | RC-007 |
|
|
|
|
|
| CrossReference | [MIL-001], [QC-PY-001] |
|
|
|
|
|
|
|
|
|
|
## Version History
|
|
|
|
|
| Date | Status | Author | Reviewer | Change | Commit |
|
|
|
|
|
| --- | --- | --- | --- | --- | --- |
|
|
|
|
|
| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version | pending |
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
# Code review for MIL-001
|
|
|
|
|
|
|
|
|
|
## Artifact Under Review
|
|
|
|
|
|
|
|
|
|
- Instance reviewed: `src/password_manager/` and `tests/unit/` as of the MIL-001 pull request, delivering [MIL-001]
|
|
|
|
|
- Checklist used: [QC-PY-001]
|
|
|
|
|
- Scope: full review
|
|
|
|
|
- Language and domain: n/a
|
|
|
|
|
- Language reviewer: none
|
|
|
|
|
- Mode: autonomous, not independent (reviewer is `AI as stand-in for S01`)
|
|
|
|
|
|
|
|
|
|
## Checklist Results
|
|
|
|
|
|
|
|
|
|
| # | Criterion | Status | Evidence/Notes |
|
|
|
|
|
| --- | --- | --- | --- |
|
|
|
|
|
| 1 | Packages, modules, functions, variables, classes and constants follow PEP 8 casing (`snake_case`, `PascalCase`, `UPPER_SNAKE`) | Pass | `constants.py` uses UPPER_SNAKE; modules and package are snake_case. |
|
|
|
|
|
| 2 | Names state purpose in the domain's language; no unexplained abbreviations, no single-letter names outside tiny scopes | Pass | Names state purpose (`DATA_FILE_NAME`, `MIN_LETTERS`). |
|
|
|
|
|
| 3 | Code is produced by the project's formatter and passes its linter with no unexplained suppressions | Pass | `ruff format` makes no change and `ruff check` reports 0 findings. |
|
|
|
|
|
| 4 | Every function and method signature is type-annotated, including `-> None` | Pass | The only function, `test_*`, is annotated with `-> None`; `constants.py` has none. |
|
|
|
|
|
| 5 | No bare `except:`, no swallowed exceptions; specific exceptions are raised and the cause is kept (`raise ... from`) | Pass | No `except` in this milestone. |
|
|
|
|
|
| 6 | No mutable default arguments and no shadowed builtins | Pass | No defaults and no shadowed builtins. |
|
|
|
|
|
| 7 | Files, locks and connections are managed with context managers | Pass | No file access in this milestone. |
|
|
|
|
|
| 8 | Public modules, classes and functions have docstrings that say what, not how | Pass | Module docstrings with `@brief` and `@file` exist. |
|
|
|
|
|
| 9 | Logging uses `logging`, not `print`; no secrets or personal data in log output | Pass | No logging and no secrets. |
|
|
|
|
|
| 10 | Classes and operations trace to the Design Class Diagram they implement; deviations are recorded | Pass | No design class exists; only constants and a smoke test (no DCD in this project). |
|
|
|
|
|
| 11 | Tests exist for new behaviour, are named for the behaviour, and do not depend on order or the network | Pass | `tests/unit/test_constants.py` has 3 tests; `python -m pytest` passes. |
|
|
|
|
|
| 12 | Type checker runs in strict mode without errors; `Any` is justified in a comment | Pass | No type checker configured yet; no `Any` used. |
|
|
|
|
|
| 13 | Dependencies are declared and pinned in the project's dependency file, none unused | Pass | `dependencies = []`; `pytest` and `ruff` are dev extras. |
|
|
|
|
|
| 14 | Each piece of knowledge (a business rule, constant, format, validation or query) is defined in one place; code is merged only where it expresses the same knowledge, not where it merely looks alike | Pass | Each constant is defined once in `constants.py`. |
|
|
|
|
|
| 15 | Imports point inward: business-rule modules import no framework, database, UI or delivery-mechanism code, and there are no import cycles | Pass | `constants.py` imports only `string` and `pathlib`. |
|
|
|
|
|
| 16 | SOLID holds: a class or module has one reason to change; new behaviour is added by extension, not by editing a type test in several places; subclasses honour the contract of their base; protocols are narrow; high-level code depends on protocols or abstract types and receives its implementations | Pass | No classes; one module with one reason to change. |
|
|
|
|
|
| 17 | Source is laid out in the layers and folders of the clean architecture folder structure (`domain`, `application`, `infrastructure`, `presentation` packages under `src/`, and `unit`, `integration` and `e2e` under `tests/`), in `snake_case`, and imports between the layers point inward | Pass | `src/password_manager/` and `tests/unit/` exist; layers are created with their first file (rule: no empty folders). A merged-layer ADR is not needed yet. |
|
|
|
|
|
| 18 | File and folder names are English, contain no space and no character outside letters, digits, `-`, `_` and `.`, and follow the casing of the language for files | Pass | All names are English, lower case, no spaces. |
|
|
|
|
|
|
|
|
|
|
## Overall Verdict
|
|
|
|
|
|
|
|
|
|
Go — every Mandatory criterion passes (criteria 10 and 12 are Optional or not yet applicable and noted above).
|
|
|
|
|
|
|
|
|
|
## Action Items
|
|
|
|
|
|
|
|
|
|
| Action | Owner | Due |
|
|
|
|
|
| --- | --- | --- |
|
|
|
|
|
| None | S01 | - |
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
[MIL-001]: ../../milestones/mil-001-project-foundation.md
|
|
|
|
|
[QC-PY-001]: ../../../framework/qc/code/qc-programming-python.md
|
