Record the re-check of the Business Case success criteria on main #37

Merged
Tirsvad merged 2 commits from rc-019-success-criteria-recheck into main 2026-10-07 19:24:15 +02:00
Owner

Record the re-check of the Business Case success criteria on main

Adds RC-019, the re-check of the seven success criteria of BC-001 against main (7d2c9e3) that RC-018 asked for, and bumps the next review number in the artifact registry (019 to 020). Nothing else changes: no code and no other document.

Result

All seven criteria are met on main:

  • The README's own GitHub clone URL now gives the project, and every README step worked in an empty folder under PowerShell (criterion 5).
  • The real command opened its window five times, and each challenge drew to completion through the command line code with real Tk (criterion 1).
  • pytest passed (95 tests), ruff and mypy are clean, and CI on main is green since #36 (criterion 2).
  • No runtime dependency (criterion 3); Doxygen builds with 0 warnings (criterion 4).
  • Description and 11 topics on Gitea and on GitHub (criterion 6).
  • Pull requests #30 to #33 carry their Closes lines (criterion 7).

Conditions of RC-018

  • Repeat the README steps with its own clone URL: met by the run in RC-019.
  • How main reaches GitHub: settled, GitHub receives main and the branches from Gitea.
  • S01's own run of the five commands (criterion 1): still open. The record is a draft with the verdict Pending; the proposed verdict is Go if S01 accepts the runs in the record as the measure.

Also noted in the record

The README's "Continuous integration" section and project layout still name .github/workflows/ci.yml and say CI builds the documentation, but the workflow is .gitea/workflows/ci.yml and has no Doxygen step. This pull request does not change the README.

Issues

No issue closed: this pull request records a check. #28 (verify the Business Case success criteria) stays open until the verdict on RC-019.

Refs #28

## Record the re-check of the Business Case success criteria on main Adds `RC-019`, the re-check of the seven success criteria of `BC-001` against `main` (`7d2c9e3`) that `RC-018` asked for, and bumps the next review number in the artifact registry (019 to 020). Nothing else changes: no code and no other document. ### Result All seven criteria are met on `main`: - The README's own GitHub clone URL now gives the project, and every README step worked in an empty folder under PowerShell (criterion 5). - The real command opened its window five times, and each challenge drew to completion through the command line code with real Tk (criterion 1). - `pytest` passed (95 tests), ruff and mypy are clean, and CI on `main` is green since #36 (criterion 2). - No runtime dependency (criterion 3); Doxygen builds with 0 warnings (criterion 4). - Description and 11 topics on Gitea and on GitHub (criterion 6). - Pull requests #30 to #33 carry their `Closes` lines (criterion 7). ### Conditions of RC-018 - Repeat the README steps with its own clone URL: met by the run in `RC-019`. - How `main` reaches GitHub: settled, GitHub receives `main` and the branches from Gitea. - S01's own run of the five commands (criterion 1): still open. The record is a draft with the verdict `Pending`; the proposed verdict is Go if S01 accepts the runs in the record as the measure. ### Also noted in the record The README's "Continuous integration" section and project layout still name `.github/workflows/ci.yml` and say CI builds the documentation, but the workflow is `.gitea/workflows/ci.yml` and has no Doxygen step. This pull request does not change the README. ### Issues No issue closed: this pull request records a check. #28 (verify the Business Case success criteria) stays open until the verdict on `RC-019`. Refs #28
Tirsvad added 2 commits 2026-10-07 19:23:17 +02:00
RC-019 repeats the check of RC-018 against main (7d2c9e3), using a fresh clone from
the README's own GitHub URL, the README steps under PowerShell, the real command,
the host's CI runs, settings and pull requests. All seven criteria are met. It
closes the conditions of RC-018 on criterion 5 and on how main reaches GitHub;
S01's own run of the five commands (criterion 1) is the one left. The proposed
verdict is Go and S01 decides.

Refs #28
Resolve pending commit links
CI / checks (push) Successful in 46s
CI / checks (pull_request) Successful in 44s
cca1499de5
Replace pending in the Version History of RC-019 with the link to the commit that
added it.
Tirsvad merged commit 1b3d2d2db1 into main 2026-10-07 19:24:15 +02:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Tirsvad-Udemy-100-days-of-code/018-turtle#37