Tirsvad-Udemy-100-days-of-code/018-turtle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Record the verdict Go on RC-019

Browse Source 
S01 accepted the assistant's runs as the measure for success criteria 1 and 5 and
recorded Go on the re-check of the Business Case success criteria on main. All seven
criteria are met, and the conditions of RC-018 are closed. The traceability matrix
row follows the verdict.

Refs #28
This commit is contained in:
Tirsvad
2026-10-08 01:28:05 +08:00
parent 1b3d2d2db1
commit 6dac0d6762
2 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/sqa/reviews/rc-019-business-case-success-criteria-recheck.md
+9 -6
View File
@@ -10,6 +10,7 @@
| Date | Status | Author | Reviewer | Change | Commit | | Date | Status | Author | Reviewer | Change | Commit |
| --- | --- | --- | --- | --- | --- | | --- | --- | --- | --- | --- | --- |
| 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [03700b8] | | 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [03700b8] |
| 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Verdict recorded: Go | pending |
--- ---
@@ -22,31 +23,33 @@
- Language reviewer: none (n/a) - Language reviewer: none (n/a)
- Method: a fresh clone of `main` from the README's own GitHub URL into an empty folder, then the README's Windows PowerShell steps, run on the author's Windows machine; the real command started from that clone; read-only calls to the Gitea and GitHub APIs for continuous integration, settings, pull requests and issues. - Method: a fresh clone of `main` from the README's own GitHub URL into an empty folder, then the README's Windows PowerShell steps, run on the author's Windows machine; the real command started from that clone; read-only calls to the Gitea and GitHub APIs for continuous integration, settings, pull requests and issues.
- Reviewer eligibility: S01 is the author and the reviewer; S01 accepted that deviation in chat on 2026-10-07 (see the traceability matrix). - Reviewer eligibility: S01 is the author and the reviewer; S01 accepted that deviation in chat on 2026-10-07 (see the traceability matrix).
- Status of this record: draft. The statuses and evidence are the assistant's, from the runs described above; they are not a decision. - Status of this record: decided on 2026-10-08 by S01, the reviewer, who recorded the verdict Go and accepted the assistant's runs as the measure for criteria 1 and 5. The statuses and evidence are the assistant's, from the runs described above.
## Checklist Results ## Checklist Results
| # | Criterion | Status | Evidence/Notes | | # | Criterion | Status | Evidence/Notes |
| --- | --- | --- | --- | | --- | --- | --- | --- |
| 1 | Challenges are runnable. Target: 5 of 5 challenges start from the command line and draw to completion. Measure: S01 runs each on Windows PowerShell and records the result in the review of the milestone. | Pass | From a fresh clone of `main` (`7d2c9e3`), in PowerShell: (a) the real command `turtle-challenges <name>` was started five times and each time a window titled "Turtle Challenges" opened (square, dashed-line, shapes, random-walk, spirograph). (b) Each challenge was run through `cli.main` with real Tk, closing the window where the command would wait for a click, and each reached that point with exit 0: square 1.4 s, dashed-line 3.3 s, shapes 14.0 s, random-walk 9.6 s, spirograph 3.6 s (1.8 s with `--gap 10`). Not covered: the click that closes the window, and S01's own run, which the measure names. The code is unchanged since the run in [RC-018]. | | 1 | Challenges are runnable. Target: 5 of 5 challenges start from the command line and draw to completion. Measure: S01 runs each on Windows PowerShell and records the result in the review of the milestone. | Pass | From a fresh clone of `main` (`7d2c9e3`), in PowerShell: (a) the real command `turtle-challenges <name>` was started five times and each time a window titled "Turtle Challenges" opened (square, dashed-line, shapes, random-walk, spirograph). (b) Each challenge was run through `cli.main` with real Tk, closing the window where the command would wait for a click, and each reached that point with exit 0: square 1.4 s, dashed-line 3.3 s, shapes 14.0 s, random-walk 9.6 s, spirograph 3.6 s (1.8 s with `--gap 10`). Not covered: the click that closes the window, and S01's own run, which the measure names. The code is unchanged since the run in [RC-018]. S01 accepted this run as the measure on 2026-10-08. |
| 2 | Automated tests pass. Target: 0 failures; at least one test for every public function. Measure: `python -m pytest` exits 0 locally and in continuous integration. | Pass | In the clone of `main`: `python -m pytest` printed `95 passed`, exit 0; `ruff check .`, `ruff format --check .` and `mypy` exit 0; the steps of the current workflow as written (`python -m ruff check src tests`, `python -m ruff format --check src tests`, `python -m mypy src tests`) pass too. Every public function and class still has a test (the code is unchanged since [RC-018]). Continuous integration on `main` at `7d2c9e3`: run 252 is `success` with the steps Install, Tests, Lint, Format check and Types. History: after #35 introduced `pip install --group dev` the workflow failed (six runs, 241 to 246); #36 fixed the install step and CI has been green since (runs 247, 249 and 252). The workflow no longer builds the documentation. | | 2 | Automated tests pass. Target: 0 failures; at least one test for every public function. Measure: `python -m pytest` exits 0 locally and in continuous integration. | Pass | In the clone of `main`: `python -m pytest` printed `95 passed`, exit 0; `ruff check .`, `ruff format --check .` and `mypy` exit 0; the steps of the current workflow as written (`python -m ruff check src tests`, `python -m ruff format --check src tests`, `python -m mypy src tests`) pass too. Every public function and class still has a test (the code is unchanged since [RC-018]). Continuous integration on `main` at `7d2c9e3`: run 252 is `success` with the steps Install, Tests, Lint, Format check and Types. History: after #35 introduced `pip install --group dev` the workflow failed (six runs, 241 to 246); #36 fixed the install step and CI has been green since (runs 247, 249 and 252). The workflow no longer builds the documentation. |
| 3 | Runtime dependencies. Target: 0. Measure: `dependencies = []` in `pyproject.toml`. | Pass | `dependencies = []` in `pyproject.toml` (read with `tomllib`), and `python -m pip show turtle-challenges` in the clone of `main` prints an empty `Requires:`. | | 3 | Runtime dependencies. Target: 0. Measure: `dependencies = []` in `pyproject.toml`. | Pass | `dependencies = []` in `pyproject.toml` (read with `tomllib`), and `python -m pip show turtle-challenges` in the clone of `main` prints an empty `Requires:`. |
| 4 | Source documentation builds. Target: 0 Doxygen warnings. Measure: `doxygen Doxyfile` output. | Pass | `doxygen Doxyfile` (Doxygen 1.15.0) in the clone of `main`: exit 0, no output, `build/html/index.html` generated. Continuous integration no longer runs this build, because the current workflow has no Doxygen step, so the evidence is the local run only; the README's "Continuous integration" section still says CI builds the documentation. | | 4 | Source documentation builds. Target: 0 Doxygen warnings. Measure: `doxygen Doxyfile` output. | Pass | `doxygen Doxyfile` (Doxygen 1.15.0) in the clone of `main`: exit 0, no output, `build/html/index.html` generated. Continuous integration no longer runs this build, because the current workflow has no Doxygen step, so the evidence is the local run only; the README's "Continuous integration" section still says CI builds the documentation. |
| 5 | Set-up is reproducible. Target: A fresh clone runs the challenges and the tests following only the README on Windows PowerShell. Measure: S01 follows the README from an empty folder. | Pass | Met. The README's own clone URL, `https://github.com/Tirsvad-Udemy-100-days-of-code/018-turtle.git`, now gives the project: `main` at `7d2c9e3` with 60 tracked files and 12 package files (GitHub receives `main` from Gitea). In an empty folder under PowerShell every README step worked: `git clone`, `py -3.13 -m venv .venv` (Python 3.13.14), `Activate.ps1`, `python -m pip install --upgrade pip` (26.2.1), `python -m pip install -e ".[dev]"` (exit 0), `python -m pytest` (95 passed), `ruff check .`, `ruff format --check .` and `mypy` (all exit 0), `turtle-challenges --help` (exit 0) and `doxygen Doxyfile` (0 warnings). This closes the condition on criterion 5 of [RC-018]. The measure names S01 following the README, which has not happened. | | 5 | Set-up is reproducible. Target: A fresh clone runs the challenges and the tests following only the README on Windows PowerShell. Measure: S01 follows the README from an empty folder. | Pass | Met. The README's own clone URL, `https://github.com/Tirsvad-Udemy-100-days-of-code/018-turtle.git`, now gives the project: `main` at `7d2c9e3` with 60 tracked files and 12 package files (GitHub receives `main` from Gitea). In an empty folder under PowerShell every README step worked: `git clone`, `py -3.13 -m venv .venv` (Python 3.13.14), `Activate.ps1`, `python -m pip install --upgrade pip` (26.2.1), `python -m pip install -e ".[dev]"` (exit 0), `python -m pytest` (95 passed), `ruff check .`, `ruff format --check .` and `mypy` (all exit 0), `turtle-challenges --help` (exit 0) and `doxygen Doxyfile` (0 warnings). This closes the condition on criterion 5 of [RC-018]. The measure names S01 following the README, which has not happened. S01 accepted this run as the measure on 2026-10-08. |
| 6 | Repository is presented. Target: Non-empty description and at least 5 topics on each host. Measure: Repository settings page of each host. | Pass | Read from the host APIs today: Gitea and GitHub both have the description "Turtle graphics exercises from Udemy's 100 Days of Code Python bootcamp (day 18): square, dashed line, polygons, random walk and spirograph." and 11 topics each; the GitHub repository is public and its default branch is `main`. | | 6 | Repository is presented. Target: Non-empty description and at least 5 topics on each host. Measure: Repository settings page of each host. | Pass | Read from the host APIs today: Gitea and GitHub both have the description "Turtle graphics exercises from Udemy's 100 Days of Code Python bootcamp (day 18): square, dashed line, polygons, random walk and spirograph." and 11 topics each; the GitHub repository is public and its default branch is `main`. |
| 7 | Work is traceable. Target: 100 % of pull requests carry one `Closes #N` line per completed issue. Measure: Pull request descriptions. | Pass | Pull requests #30 to #33 each carry their `Closes #N` lines one per line and no comma form (#30: 1 to 6; #31: 9 to 14; #32: 16 to 21; #33: 23 to 26 and 8, 15, 22, 29). #34, #35 and #36 complete no issue and carry no `Closes` line. Only #34 says so explicitly; #35 and #36 do not, and the project-planning rule asks a pull request that finishes no issue to say so. 28 of the 29 issues are closed (#7 and #27 by hand, the others through the `Closes` lines); #28 is open. | | 7 | Work is traceable. Target: 100 % of pull requests carry one `Closes #N` line per completed issue. Measure: Pull request descriptions. | Pass | Pull requests #30 to #33 each carry their `Closes #N` lines one per line and no comma form (#30: 1 to 6; #31: 9 to 14; #32: 16 to 21; #33: 23 to 26 and 8, 15, 22, 29). #34, #35 and #36 complete no issue and carry no `Closes` line. Only #34 says so explicitly; #35 and #36 do not, and the project-planning rule asks a pull request that finishes no issue to say so. 28 of the 29 issues are closed (#7 and #27 by hand, the others through the `Closes` lines); #28 is open. |
## Overall Verdict ## Overall Verdict
Pending — a draft prepared for the reviewer (S01), who decides and replaces this line with the verdict. Proposed verdict: Go, if S01 accepts the runs in this record as the measure for criteria 1 and 5; otherwise Go-with-conditions until S01 has made those two runs. Go — all seven success criteria of [BC-001] are met on `main` (`7d2c9e3`). The Business Case names S01 for the runs behind criteria 1 and 5; S01 accepted the assistant's runs in this record as that measure on 2026-10-08.
Rationale: all seven success criteria are met on `main`. The conditions of [RC-018] stand as follows. Criterion 5 (repeat the README steps with its own clone URL) is met by the run above. The decision on how `main` reaches GitHub is settled: GitHub receives `main` and the branches from Gitea. The run of the five commands by S01 (criterion 1) is the one condition left, and only S01 can accept the assistant's run in its place. Go / No-Go criterion 6 of [MIL-004] ("every criterion met") is met once S01 decides. No date moved, so the Project Plan needs no schedule change. This closes the conditions of [RC-018]: criterion 5 is met by the README run from its own GitHub clone URL, GitHub receives `main` and the branches from Gitea, and the run of the five commands (criterion 1) is accepted. Go / No-Go criterion 6 of [MIL-004] ("every criterion met") is therefore met. No date moved, so the Project Plan needs no schedule change.
Reviewer eligibility: S01 is the author and the reviewer, which the review process does not allow; S01 accepted that deviation in chat on 2026-10-07 and it is recorded in the traceability matrix.
## Action Items ## Action Items
| Action | Owner | Due | | Action | Owner | Due |
| --- | --- | --- | | --- | --- | --- |
| Condition (criteria 1 and 5): accept the runs in this record as the measure, or run the five commands yourself on Windows PowerShell (click the window to close it) and follow the README from an empty folder, and record the result. | S01 | 2026-10-21 | | Condition (criteria 1 and 5): accept the runs in this record as the measure, or run the five commands yourself on Windows PowerShell (click the window to close it) and follow the README from an empty folder, and record the result. Closed 2026-10-08: S01 accepted the runs in this record as the measure. | S01 | 2026-10-21 |
| After the verdict `Go`: close issue #28. | S01 | 2026-10-21 | | After the verdict `Go`: close issue #28. | S01 | 2026-10-21 |
| The README's "Continuous integration" section and its project layout still name `.github/workflows/ci.yml` and say CI builds the documentation; the workflow is now `.gitea/workflows/ci.yml` and has no Doxygen step. Correct the README, or restore the step. | S01 | 2026-10-21 | | The README's "Continuous integration" section and its project layout still name `.github/workflows/ci.yml` and say CI builds the documentation; the workflow is now `.gitea/workflows/ci.yml` and has no Doxygen step. Correct the README, or restore the step. | S01 | 2026-10-21 |
| Decide whether continuous integration should build the documentation again; today criterion 4 rests on a local run only. | S01 | 2026-10-21 | | Decide whether continuous integration should build the documentation again; today criterion 4 rests on a local run only. | S01 | 2026-10-21 |
docs/sqa/traceability-matrix.md
+4 -4
View File
@@ -9,8 +9,8 @@
## Version History ## Version History
| Date | Status | Author | Reviewer | Change | Commit | | Date | Status | Author | Reviewer | Change | Commit |
| --- | --- | --- | --- | --- | --- | | --- | --- | --- | --- | --- | --- |
| 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Added the row for the check of the success criteria of [BC-001], with [RC-018] | [88aee40] |
| 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Recorded the verdict Go-with-conditions of [RC-018] | [54f60a9] | | 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Recorded the verdict Go-with-conditions of [RC-018] | [54f60a9] |
| 2026-10-08 | Proposed | Jens Tirsvad Nielsen | S01 | Recorded the verdict Go of [RC-019], the re-check of [RC-018] | pending |
--- ---
@@ -36,14 +36,14 @@ updated whenever an artifact instance is created or reviewed.
| Python source code of milestone 002 (`src/`, `tests/`, branch `mil-002-square-and-dashed-line`) | PY | - | - | [MIL-002] | - | [RC-015] (Go) | | Python source code of milestone 002 (`src/`, `tests/`, branch `mil-002-square-and-dashed-line`) | PY | - | - | [MIL-002] | - | [RC-015] (Go) |
| Python source code of milestone 003 (`src/`, `tests/`, branch `mil-003-shapes-and-random-color`) | PY | - | - | [MIL-003] | - | [RC-016] (Go) | | Python source code of milestone 003 (`src/`, `tests/`, branch `mil-003-shapes-and-random-color`) | PY | - | - | [MIL-003] | - | [RC-016] (Go) |
| Python source code of milestone 004 (`src/`, `tests/`, branch `mil-004-random-walk-and-spirograph`) | PY | - | - | [MIL-004] | - | [RC-017] (Go) | | Python source code of milestone 004 (`src/`, `tests/`, branch `mil-004-random-walk-and-spirograph`) | PY | - | - | [MIL-004] | - | [RC-017] (Go) |
| Success criteria of [BC-001], checked against the delivered repository for the gate of [MIL-004] | BC | en | it | [BC-001], [MIL-004] | - | [RC-018] (Go-with-conditions) | | Success criteria of [BC-001], checked against the delivered repository for the gate of [MIL-004] | BC | en | it | [BC-001], [MIL-004] | - | [RC-019] (Go), the re-check of [RC-018] (Go-with-conditions) |
## Coverage Notes ## Coverage Notes
- `-` in Upstream means foundational ([SA-001] is the foundation of the stakeholder IDs); in Downstream it means nothing is built on it yet ([MIL-004] is the last gateway; the source code is listed per milestone in the `PY` rows); in Last Reviewed it means no `RC-*` exists. - `-` in Upstream means foundational ([SA-001] is the foundation of the stakeholder IDs); in Downstream it means nothing is built on it yet ([MIL-004] is the last gateway; the source code is listed per milestone in the `PY` rows); in Last Reviewed it means no `RC-*` exists.
- [PP-001] has no `RC-*` because the Project Plan has no QC checklist; the Product Owner accepted it directly on 2026-10-08. - [PP-001] has no `RC-*` because the Project Plan has no QC checklist; the Product Owner accepted it directly on 2026-10-08.
- The `PY` rows list the Python code each milestone added or changed, reviewed against `QC-PY-001`. Their records, [RC-014] to [RC-017], ended in `Go` on 2026-10-08; a `-` in Language and Domain is right for source code, a technical type. - The `PY` rows list the Python code each milestone added or changed, reviewed against `QC-PY-001`. Their records, [RC-014] to [RC-017], ended in `Go` on 2026-10-08; a `-` in Language and Domain is right for source code, a technical type.
- [RC-018] checks the seven success criteria of [BC-001] against the delivered repository, as the evidence for the gate of [MIL-004]. It ended in Go-with-conditions on 2026-10-08: criterion 5 is not met until the code is on `main` and on GitHub, and its first three action items are the conditions. A later record that names it re-checks them. - [RC-018] checks the seven success criteria of [BC-001] against the delivered repository, as the evidence for the gate of [MIL-004]. It ended in Go-with-conditions on 2026-10-08: criterion 5 is not met until the code is on `main` and on GitHub, and its first three action items are the conditions. A later record that names it re-checks them. Its conditions were re-checked in [RC-019], which ended in Go on 2026-10-08, so the row lists [RC-019] as the latest record.
- Each artifact lists its latest review record: the delta re-review ([RC-008] to [RC-013]) of the first review ([RC-001] to [RC-006]), or [RC-007] for [DICT-001]. All of them ended in `Go` on 2026-10-07. - Each artifact lists its latest review record: the delta re-review ([RC-008] to [RC-013]) of the first review ([RC-001] to [RC-006]), or [RC-007] for [DICT-001]. All of them ended in `Go` on 2026-10-07.
- S01 is the author and also the reviewer of every artifact. The review process does not allow this; S01 accepted the deviation in chat on 2026-10-07 because the project has one person and no governance document (`GOV`) exists. - S01 is the author and also the reviewer of every artifact. The review process does not allow this; S01 accepted the deviation in chat on 2026-10-07 because the project has one person and no governance document (`GOV`) exists.
- No instance exists yet for the types KPI, RA, BMC, BPMN, UCD, US, UC, DM, SSD, OC, SD, DCD, ERD, ADR, GOV or TRR. One of them matters for the open reviews: GOV (the rule that the reviewer is not the author). - No instance exists yet for the types KPI, RA, BMC, BPMN, UCD, US, UC, DM, SSD, OC, SD, DCD, ERD, ADR, GOV or TRR. One of them matters for the open reviews: GOV (the rule that the reviewer is not the author).
@@ -76,5 +76,5 @@ updated whenever an artifact instance is created or reviewed.
[RC-016]: ./reviews/rc-016-code-mil-003.md [RC-016]: ./reviews/rc-016-code-mil-003.md
[RC-017]: ./reviews/rc-017-code-mil-004.md [RC-017]: ./reviews/rc-017-code-mil-004.md
[RC-018]: ./reviews/rc-018-business-case-success-criteria.md [RC-018]: ./reviews/rc-018-business-case-success-criteria.md
[88aee40]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-turtle/commit/88aee4051d3fd7a915bc793c157e421f607e3034 [RC-019]: ./reviews/rc-019-business-case-success-criteria-recheck.md
[54f60a9]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-turtle/commit/54f60a951a3a6d3c6c78de373e3b76720e48639c [54f60a9]: https://git.tirsystem.com/Tirsvad-Udemy-100-days-of-code/018-turtle/commit/54f60a951a3a6d3c6c78de373e3b76720e48639c