Accept the DRY, dependency and SOLID criteria in six checklists (author as stand-in for S02) #7

Merged
Tirsvad merged 2 commits from accept-code-structure-criteria into main 2026-10-09 11:02:42 +02:00
Owner

Summary

Sets the Version History row of the six checklists that gained criteria in PR 5 to Accepted (the Proposed row becomes Deprecated): qc-dcd.md (criterion 9), qc-programming-python.md (14 to 16), qc-programming-c.md (14 to 15), qc-programming-cpp.md (14 to 16), qc-programming-csharp.md (14 to 16) and qc-programming-shell.md (15). No criterion changes. The acceptance takes effect when a reviewer merges this pull request.

How it is accepted

Coding-standard changes are accepted by S02, with S06 consulted (Coding Standards Governance). Each new row says it is accepted by the author as stand-in for S02, and that the delta re-review of the new criteria is a draft confirmed by the author as stand-in, not independently. So this is not an independent acceptance; the reviewers should decide whether it is enough. If it is not, close this PR and the rows stay Proposed.

The one open question for S02 in the review records is whether the SOLID criterion stays Mandatory (it is one compound criterion in the Python, C++ and C# checklists). Accepting here keeps it Mandatory; changing it later is a new Version History row.

After the merge

The framework's qc/ pointer is at 577520d, where these rows are Proposed. A later framework release moves it to the commit this PR creates, so projects get the accepted rows (the v0.5.0 changelog says so).

Checks

  • Only the Version History rows change (12 lines added, 12 removed); no criterion, Common Defects line or link outside those rows.
  • No instance, review record or stakeholder ID other than the S02 reviewer cell appears in the added text.

Issues

No issue closed: this change has no issue.

## Summary Sets the Version History row of the six checklists that gained criteria in PR 5 to `Accepted` (the `Proposed` row becomes `Deprecated`): `qc-dcd.md` (criterion 9), `qc-programming-python.md` (14 to 16), `qc-programming-c.md` (14 to 15), `qc-programming-cpp.md` (14 to 16), `qc-programming-csharp.md` (14 to 16) and `qc-programming-shell.md` (15). No criterion changes. **The acceptance takes effect when a reviewer merges this pull request.** ## How it is accepted Coding-standard changes are accepted by S02, with S06 consulted (Coding Standards Governance). Each new row says it is **accepted by the author as stand-in for S02**, and that the delta re-review of the new criteria is a draft confirmed by the author as stand-in, not independently. So this is not an independent acceptance; the reviewers should decide whether it is enough. If it is not, close this PR and the rows stay `Proposed`. The one open question for S02 in the review records is whether the SOLID criterion stays `Mandatory` (it is one compound criterion in the Python, C++ and C# checklists). Accepting here keeps it `Mandatory`; changing it later is a new Version History row. ## After the merge The framework's `qc/` pointer is at `577520d`, where these rows are `Proposed`. A later framework release moves it to the commit this PR creates, so projects get the accepted rows (the v0.5.0 changelog says so). ## Checks - Only the Version History rows change (12 lines added, 12 removed); no criterion, Common Defects line or link outside those rows. - No instance, review record or stakeholder ID other than the `S02` reviewer cell appears in the added text. ## Issues No issue closed: this change has no issue.
Tirsvad added 2 commits 2026-10-09 09:31:07 +02:00
The Version History row of each of the six checklists that gained criteria
(QC-DCD, QC-PY, QC-CL, QC-CPP, QC-CS, QC-SH) is Accepted, and the Proposed row
becomes Deprecated. Each row says it was accepted by the author as stand-in for
S02 (Coding Standards Governance) and that the delta re-review is a draft
confirmed by the author as stand-in, not independently. The acceptance takes
effect when a reviewer merges this pull request.
Tirsvad merged commit 037f07d8f4 into main 2026-10-09 11:02:42 +02:00
Sign in to join this conversation.