Tirsvad
a04b578d70
TirSystem/github-action: Publish wiki / publish-wiki (push) Skipped
TirSystem/github-action: Sync GitHub mirror metadata / sync-metadata (push) Skipped
Validate workflows / validate (pull_request) Successful in 15s
3.2 KiB
3.2 KiB
Review Record: ADR-0006
Metadata
| Key | Value |
|---|---|
| ID | RC-043 |
| CrossReference | ADR-0006, QC-ADR-001 |
Version History
| Date | Status | Author | Reviewer | Change | Commit |
|---|---|---|---|---|---|
| 2026-10-10 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version | 044d8ba |
Artifact Under Review
- Instance reviewed: ADR-0006
- Checklist used: QC-ADR-001
Checklist Results
| # | Criterion | Status | Evidence/Notes |
|---|---|---|---|
| 1 | The ID (ADR-NNNN, 4-digit) matches the filename number and is unique and sequential |
Pass | ADR-0006 in adr-0006-release-process-and-version-pinning.md. |
| 2 | Context states the problem, the forces (cost, risk, constraints) and the options evaluated | Pass | Names that every consumer runs main, what can and cannot be pinned, and the options. |
| 3 | At least two options were considered, or the absence of alternatives is justified | Pass | Four options for the version unit and three for the pin. |
| 4 | Decision is stated in one or two unhedged sentences and matches one of the evaluated options | Pass | Two sentences; options 1 and b. |
| 5 | Consequences list both Positive and Negative outcomes | Pass | Three positive and four negative. |
| 6 | Quality-attribute impacts (performance, security, portability, etc.) are named where the decision affects them | Pass | Reliability for consumers and the security of tag permissions and of a bad merge of a scoped file are named. |
| 7 | Affected Artifacts are listed as links, and each is also in CrossReference | Pass | MIL-004, UC-006, US-001, ADR-0005 and ADR-0004 are linked and cited. |
| 8 | Status changes are recorded as new Version History rows with a Change summary and Commit link; retained rows are never rewritten | Pass | The earlier row is kept and only its status changed. |
| 9 | A superseded or deprecated ADR names its successor, and the successor links back | N-A | Nothing is superseded. |
| 10 | Written in business or technical language of the domain, with no unexplained abbreviations | Pass | Finding fixed during this review: SemVer was used without being expanded; it is now introduced as semantic version (SemVer). |
| 11 | Status is one of Proposed, Accepted, Rejected, Deprecated or Superseded by ADR-NNNN, and every Version History row uses only these |
Pass | Deprecated and Accepted only. |
Overall Verdict
Go - all applicable criteria pass; the one finding (criterion 10) was fixed during the review. It unlocks tasks 2 to 5 of MIL-004 (#21 to #24) under the plan-first gate. S01 gave the Go in chat on 2026-10-10, standing in for the other reviewers as ADR-0002 records; there is no independent reader.
Action Items
| Action | Owner | Due |
|---|---|---|
Pin the scripts fetched by the two scoped workflows to v1 once it exists (the workflows still say ref: main) |
S05 | 2026-11-28 |
Review who may merge to main and who may move tags, since a scoped workflow file cannot be pinned by consumers |
S01 | 2026-11-14 |