github-action/docs/sqa/reviews/rc-047-adr-0007.md

Review Record: ADR-0007

Metadata

Key	Value
ID	RC-047
CrossReference	ADR-0007, QC-ADR-001

Version History

Date	Status	Author	Reviewer	Change	Commit
2026-10-10	Accepted	Jens Tirsvad Nielsen	S01	Initial version	d9cd3c6

---

Artifact Under Review

• Instance reviewed: ADR-0007
• Checklist used: QC-ADR-001

Checklist Results

#	Criterion	Status	Evidence/Notes
1	The ID (ADR-NNNN, 4-digit) matches the filename number and is unique and sequential	Pass	ADR-0007 in adr-0007-release-publish-destination.md, after ADR-0006.
2	Context states the problem, the forces (cost, risk, constraints) and the options evaluated	Pass	States what the repository contains, what the API offers and the two sensitive writes.
3	At least two options were considered, or the absence of alternatives is justified	Pass	Four options for the destination and three for the permission.
4	Decision is stated in one or two unhedged sentences and matches one of the evaluated options	Pass	Options 1 and a, with a named fallback b; the fallback is conditional on a fact the ADR says is unverified.
5	Consequences list both Positive and Negative outcomes	Pass	Three positive and three negative.
6	Quality-attribute impacts (performance, security, portability, etc.) are named where the decision affects them	Pass	Security (permission scope and secret) and portability (no release page on GitHub) are named.
7	Affected Artifacts are listed as links, and each is also in CrossReference	Pass	MIL-004, UC-006 and ADR-0006 are linked and cited.
8	Status changes are recorded as new Version History rows with a Change summary and Commit link; retained rows are never rewritten	Pass	Initial row only.
9	A superseded or deprecated ADR names its successor, and the successor links back	N-A	Nothing is superseded.
10	Written in business or technical language of the domain, with no unexplained abbreviations	Pass	No abbreviation without expansion.
11	Status is one of Proposed, Accepted, Rejected, Deprecated or Superseded by ADR-NNNN, and every Version History row uses only these	Pass	Accepted.

Overall Verdict

Go - all applicable criteria pass. The behaviour of the job token is an assumption that the first run of the release workflow (task 5) verifies, with the fallback already named. S01 gave the Go in chat on 2026-10-10, standing in for the other reviewers as ADR-0002 records; there is no independent reader.

Action Items

Action	Owner	Due
Verify in the first run of the release workflow that the job token creates the tag and moves the major tag; if not, create TOKEN_FOR_GITEA_RELEASE	S05	2026-11-28

---