From 3d7a9df3a3a4712dcc5214a71b0569d90122bf4e Mon Sep 17 00:00:00 2001 From: Jens Tirsvad Nielsen Date: Wed, 14 Oct 2026 16:00:04 +0800 Subject: [PATCH 1/2] Review and accept MIL-011 (RC-076) First read found three corrections: the wording of O5 in the traceability, "ten milestones" in the plan's purpose, and a scope row that is not a Business Case item. Go; accepted by the author as stand-in for S01, not independent. MIL-011 and its plan row are Accepted; the traceability matrix has the new rows. --- docs/artifact-registry.md | 2 +- .../mil-011-code-metrics-default-tools-ref.md | 4 +- docs/project-plan.md | 7 +- docs/sqa/reviews/rc-076-mil-011-plan.md | 66 +++++++++++++++++++ docs/sqa/traceability-matrix.md | 11 ++-- 5 files changed, 79 insertions(+), 11 deletions(-) create mode 100644 docs/sqa/reviews/rc-076-mil-011-plan.md diff --git a/docs/artifact-registry.md b/docs/artifact-registry.md index 8500754..af8ffd4 100644 --- a/docs/artifact-registry.md +++ b/docs/artifact-registry.md @@ -11,7 +11,7 @@ each document lives in *this* project and the next version to use. | SA | Stakeholder Analysis | docs/stakeholder-analysis.md | 002 | | PP | Project Plan | docs/project-plan.md | 002 | | MIL | Milestone / Gateway | docs/milestones/*.md | 012 | -| RC | SQA Review Record | docs/sqa/reviews/rc-*.md | 076 | +| RC | SQA Review Record | docs/sqa/reviews/rc-*.md | 077 | | TM | Traceability Matrix | docs/sqa/traceability-matrix.md | 002 | | ADR | Architecture Decision Record | docs/adr/adr-NNNN-*.md | 0011 | | UCD | Use Case Diagram | docs/use-case-diagram.md | 002 | diff --git a/docs/milestones/mil-011-code-metrics-default-tools-ref.md b/docs/milestones/mil-011-code-metrics-default-tools-ref.md index ad99ba8..d207093 100644 --- a/docs/milestones/mil-011-code-metrics-default-tools-ref.md +++ b/docs/milestones/mil-011-code-metrics-default-tools-ref.md @@ -9,7 +9,7 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Initial version | [02e3794] | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version; reviewed (RC-076), accepted by the author in chat as stand-in for S01 | [02e3794] | --- @@ -49,7 +49,7 @@ A patch release (`2.1.1`, [ADR-0006]) in which: the default `tools-ref` of every | Business Case objective / KPI / user story | Reference | | --- | --- | -| Business Case objective O5 (shared workflows that a repository can call without writing its own) | [BC-001] | +| Business Case objective O5: a shared workflow that counts the code files and lines of code, reads the coverage report and publishes the three results as SVG badges; the workflow cannot be called as documented until this milestone is done | [BC-001] | | User stories | [US-001] (no new story: the tasks below are technical, and the story of [MIL-010] for the badges stays as written) | ## Ownership diff --git a/docs/project-plan.md b/docs/project-plan.md index 35f75e4..2f36684 100644 --- a/docs/project-plan.md +++ b/docs/project-plan.md @@ -10,13 +10,13 @@ | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | | 2026-10-14 | Deprecated | Jens Tirsvad Nielsen | AI as stand-in for S01 | Added MIL-010 (code metrics and coverage badges); reviewed (RC-068) | [5002450] | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-011 (fix the defaults of the code metrics workflow); not yet reviewed | [02e3794] | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Added MIL-011 (fix the defaults of the code metrics workflow); reviewed (RC-076), accepted by the author in chat as stand-in for S01 | [02e3794] | --- ## Purpose -This plan schedules ten milestones that move the repository from one +This plan schedules eleven milestones that move the repository from one workflow with known defects to a documented, versioned collection of shared workflows. The Business Case sets no deadline, so the dates are the plan's own; they were confirmed on 2026-10-10 by S01, standing in for S05 (ADR-0002). @@ -83,8 +83,7 @@ Project starts 2026-10-05 | Gitea Actions workflows for software engineers (quality checks for C++ and C#) | [MIL-007] | | The wiki publisher as a workflow that repositories call, from docs/wiki | [MIL-008] | | Moving every publishing repository to the called workflow and removing the scoped one | [MIL-009] | -| A shared workflow for code metrics and coverage badges | [MIL-010] | -| The code metrics workflow works with its documented defaults | [MIL-011] | +| A shared workflow for code metrics and coverage badges | [MIL-010], [MIL-011] | ## Dependencies diff --git a/docs/sqa/reviews/rc-076-mil-011-plan.md b/docs/sqa/reviews/rc-076-mil-011-plan.md new file mode 100644 index 0000000..0d392a9 --- /dev/null +++ b/docs/sqa/reviews/rc-076-mil-011-plan.md @@ -0,0 +1,66 @@ +# Review Record: MIL-011 and PP-001 (MIL-011) + +## Metadata +| Key | Value | +| --- | --- | +| ID | RC-076 | +| CrossReference | [MIL-011], [PP-001], [BC-001], [QC-MIL-001] | + +## Version History +| Date | Status | Author | Reviewer | Change | Commit | +| --- | --- | --- | --- | --- | --- | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version; accepted by the author in chat as stand-in for S01, after three corrections found in the first read | pending | + +--- + +## Artifact Under Review + +- Instance reviewed: [MIL-011]; delta of [PP-001] for the added milestone +- Checklist used: [QC-MIL-001] for the milestone; for the plan, the criteria of `PP.md` (no QC checklist exists for PP-001) +- Scope: full review of MIL-011; delta re-review of PP-001, earlier record [RC-068] +- Language and domain: n/a (technical type) +- Mode: supervised, not independent (the author, Jens Tirsvad Nielsen, asked in chat on 2026-10-14 for the review and the acceptance and stands in for S01; the AI prepared the evidence) + +## Checklist Results + +| # | Criterion | Status | Evidence/Notes | +| --- | --- | --- | --- | +| 1 | A concrete deliverable is defined for every gate | Pass | `## Deliverable` names the patch release 2.1.1: the defaults, the test, the guides, README and three wiki languages at `@v2`, the changelog entry, and the framework `Badges` page without the workaround. | +| 2 | Explicit Go/No-Go criteria are stated for each gate | Pass | Eight criteria, each with a checkable Go and No-Go: reproduction, a list per workflow, a test that fails on a seeded default, a search that finds no `@v1`, a run on the instance, the release level and tags, the framework page, the review record. | +| 3 | Dependencies on other milestones are explicitly mapped | Pass | [MIL-010] (the workflow and its guide) and [ADR-0006] (the release process); in the plan's dependency diagram (`MIL-010 -> MIL-011`). | +| 4 | Each milestone is traceable to a Business Case objective or KPI | Pass | O5 of [BC-001]; the first read found its wording paraphrased wrongly, now quoted from the Business Case. | +| 5 | Milestone owner and approving reviewer are identified | Pass | Owner S05, approving reviewer S01; both are in [SA-001]. | +| 6 | Milestone has a defined target date consistent with project constraints | Pass | 2026-10-23; the Business Case sets no deadline. The date precedes the planned decision date of [MIL-010] (2027-01-30) because that milestone was released on 2026-10-14; the milestone says so and does not change the MIL-010 row. | + +## Plan delta (PP-001) + +| # | Criterion | Status | Evidence/Notes | +| --- | --- | --- | --- | +| 1 | Every milestone has a `MIL-*` document and the plan's dates equal that document's target date | Pass | MIL-001 to MIL-011 exist; the MIL-011 decision date (2026-10-23) equals its Target Date. | +| 2 | Every Business Case scope item is covered by a gateway | Pass | The first read found a scope row that is not a Business Case item; it is removed and MIL-011 is listed beside MIL-010 for the badges item. | +| 3 | The schedule respects the Business Case constraints | Pass | No deadline in the Business Case; the window is one week. | +| 4 | Dependencies between milestones are stated | Pass | `MIL-003 + MIL-004 -> MIL-010 -> MIL-011`. | +| 5 | Every gateway has an owner who is a stakeholder ID | Pass | S05. | +| 6 | Plan content is internally consistent | Pass | The first read found "ten milestones" in the Purpose; it is now "eleven", and the Gantt, the schedule and the dependencies agree. | +| 7 | Open Issues are current | Pass | No plan risk was added for a default that names an old major; the release process and the test of task 3 carry the rule. Observation, not a failure. | + +## Overall Verdict + +Go - all criteria pass after three corrections found in the first read (the O5 wording, "ten milestones", and a scope row that was not a Business Case item). The author confirmed the acceptance in chat on 2026-10-14 as stand-in for S01; this is not an independent review. + +## Action Items + +| Action | Owner | Due | +| --- | --- | --- | +| Confirm this record by S01 when an independent reading is possible | S01 | 2026-10-30 | +| Task 1: reproduce the failure and list the defaults before any change to the workflows | S05 | 2026-10-16 | + +--- + +[MIL-011]: ../../milestones/mil-011-code-metrics-default-tools-ref.md +[PP-001]: ../../project-plan.md +[BC-001]: ../../business-case.md +[SA-001]: ../../stakeholder-analysis.md +[ADR-0006]: ../../adr/adr-0006-release-process-and-version-pinning.md +[RC-068]: ./rc-068-mil-010-plan.md +[QC-MIL-001]: ../../../framework/qc/artifacts/qc-milestones-gateways.md diff --git a/docs/sqa/traceability-matrix.md b/docs/sqa/traceability-matrix.md index 7410bbd..072fdb9 100644 --- a/docs/sqa/traceability-matrix.md +++ b/docs/sqa/traceability-matrix.md @@ -4,13 +4,13 @@ | Key | Value | | --- | --- | | ID | TM-001 | -| CrossReference | [BC-001], [SA-001], [PP-001], [MIL-001], [MIL-002], [MIL-003], [MIL-004], [MIL-005], [MIL-006], [MIL-007], [MIL-008], [MIL-009], [MIL-010], [UC-008], [RC-001], [RC-002], [RC-003], [RC-004], [RC-005], [RC-006], [RC-007], [RC-008], [RC-009], [RC-010], [RC-011], [RC-012], [RC-013], [RC-014], [RC-015], [RC-016], [RC-017], [RC-018], [RC-019], [RC-020], [RC-021], [RC-022], [RC-023], [RC-024], [RC-025], [RC-026], [RC-027], [RC-028], [RC-029], [RC-030], [RC-031], [RC-032], [RC-033], [RC-034], [RC-035], [RC-036], [RC-037], [RC-038], [RC-039], [RC-040], [RC-041], [RC-042], [RC-043], [RC-044], [RC-045], [RC-046], [RC-047], [RC-048], [RC-049], [RC-050], [RC-051], [RC-052], [RC-053], [RC-054], [RC-055], [RC-056], [RC-057], [RC-058], [RC-059], [RC-060], [RC-061], [RC-062], [RC-063], [RC-064], [RC-065], [RC-066], [RC-067], [RC-068], [RC-069], [RC-070], [RC-071], [RC-072], [RC-073], [RC-074], [RC-075], [ADR-0007], [ADR-0008], [ADR-0009], [ADR-0010], [UC-007], [UC-006], [ADR-0006], [UC-005], [ADR-0005], [UCD-001], [US-001], [UC-001], [UC-002], [UC-003], [UC-004], [ADR-0001], [ADR-0002], [ADR-0003], [ADR-0004] | +| CrossReference | [BC-001], [SA-001], [PP-001], [MIL-001], [MIL-002], [MIL-003], [MIL-004], [MIL-005], [MIL-006], [MIL-007], [MIL-008], [MIL-009], [MIL-010], [MIL-011], [UC-008], [RC-001], [RC-002], [RC-003], [RC-004], [RC-005], [RC-006], [RC-007], [RC-008], [RC-009], [RC-010], [RC-011], [RC-012], [RC-013], [RC-014], [RC-015], [RC-016], [RC-017], [RC-018], [RC-019], [RC-020], [RC-021], [RC-022], [RC-023], [RC-024], [RC-025], [RC-026], [RC-027], [RC-028], [RC-029], [RC-030], [RC-031], [RC-032], [RC-033], [RC-034], [RC-035], [RC-036], [RC-037], [RC-038], [RC-039], [RC-040], [RC-041], [RC-042], [RC-043], [RC-044], [RC-045], [RC-046], [RC-047], [RC-048], [RC-049], [RC-050], [RC-051], [RC-052], [RC-053], [RC-054], [RC-055], [RC-056], [RC-057], [RC-058], [RC-059], [RC-060], [RC-061], [RC-062], [RC-063], [RC-064], [RC-065], [RC-066], [RC-067], [RC-068], [RC-069], [RC-070], [RC-071], [RC-072], [RC-073], [RC-074], [RC-075], [ADR-0007], [ADR-0008], [ADR-0009], [ADR-0010], [UC-007], [UC-006], [ADR-0006], [UC-005], [ADR-0005], [UCD-001], [US-001], [UC-001], [UC-002], [UC-003], [UC-004], [ADR-0001], [ADR-0002], [ADR-0003], [ADR-0004] | ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-074 (MIL-010 results of tasks 3, 6 and 8) | [5c5a1d1] | | 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-075 (MIL-010 outcome, release 2.1.0) | [aa20e56] | +| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-011 and RC-076 (fix the defaults of the code metrics workflow) | pending | --- @@ -43,7 +43,8 @@ updated whenever an artifact instance is created or reviewed. | [MIL-007] | MIL | [BC-001], [PP-001], [MIL-003], [MIL-004], [ADR-0008] | - | [RC-052], [RC-055], [RC-059] | | [MIL-008] | MIL | [BC-001], [PP-001], [MIL-006], [ADR-0004] | [MIL-009] | [RC-060], [RC-061] | | [MIL-009] | MIL | [BC-001], [PP-001], [MIL-008], [ADR-0004], [ADR-0006], [ADR-0009] | - | [RC-064], [RC-066] | -| [MIL-010] | MIL | [BC-001], [PP-001], [MIL-003], [MIL-004] | - | [RC-068], [RC-074], [RC-075] | +| [MIL-010] | MIL | [BC-001], [PP-001], [MIL-003], [MIL-004] | [MIL-011] | [RC-068], [RC-074], [RC-075] | +| [MIL-011] | MIL | [BC-001], [PP-001], [MIL-010], [ADR-0006], [ADR-0010] | - | [RC-076] | | [RC-007] | RC | [MIL-004] | - | - | | [RC-008] | RC | [BC-001] | - | - | | [RC-009] | RC | [PP-001] | - | - | @@ -132,6 +133,7 @@ updated whenever an artifact instance is created or reviewed. | [RC-073] | RC | [ADR-0010] | - | - | | [RC-074] | RC | [MIL-010] | - | - | | [RC-075] | RC | [MIL-010] | - | - | +| [RC-076] | RC | [MIL-011], [PP-001] | - | - | ## Coverage Notes @@ -154,6 +156,7 @@ updated whenever an artifact instance is created or reviewed. [MIL-007]: ../milestones/mil-007-cpp-csharp-quality-checks.md [MIL-008]: ../milestones/mil-008-wiki-reusable-workflow.md [MIL-010]: ../milestones/mil-010-code-metrics-badges.md +[MIL-011]: ../milestones/mil-011-code-metrics-default-tools-ref.md [MIL-009]: ../milestones/mil-009-migrate-wiki-callers-and-remove-scoped-workflow.md [ADR-0010]: ../adr/adr-0010-code-metrics-badges-contract.md [RC-001]: ./reviews/rc-001-business-case.md @@ -241,6 +244,7 @@ updated whenever an artifact instance is created or reviewed. [RC-073]: ./reviews/rc-073-adr-0010-artifact.md [RC-074]: ./reviews/rc-074-mil-010-results.md [RC-075]: ./reviews/rc-075-mil-010-outcome.md +[RC-076]: ./reviews/rc-076-mil-011-plan.md [ADR-0008]: ../adr/adr-0008-cpp-csharp-quality-check-contract.md [ADR-0009]: ../adr/adr-0009-wiki-publishing-reusable-workflow.md [ADR-0007]: ../adr/adr-0007-release-publish-destination.md @@ -250,5 +254,4 @@ updated whenever an artifact instance is created or reviewed. [ADR-0006]: ../adr/adr-0006-release-process-and-version-pinning.md [UC-005]: ../uc-005/uc.md [ADR-0005]: ../adr/adr-0005-quality-check-contract.md -[5c5a1d1]: https://git.tirsystem.com/TirSystem/github-action/commit/5c5a1d19d96a6979b4f6141e736957174ba686a9 [aa20e56]: https://git.tirsystem.com/TirSystem/github-action/commit/aa20e56110f4c2fab91a8432ba008ee8300926a2 -- 2.54.0 From 60da2583d13ce802178aae5a99e9a61a1c0f0ac7 Mon Sep 17 00:00:00 2001 From: Jens Tirsvad Nielsen Date: Wed, 14 Oct 2026 16:00:05 +0800 Subject: [PATCH 2/2] Resolve pending commit links for RC-076 --- docs/sqa/reviews/rc-076-mil-011-plan.md | 3 ++- docs/sqa/traceability-matrix.md | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/sqa/reviews/rc-076-mil-011-plan.md b/docs/sqa/reviews/rc-076-mil-011-plan.md index 0d392a9..0b1d6d0 100644 --- a/docs/sqa/reviews/rc-076-mil-011-plan.md +++ b/docs/sqa/reviews/rc-076-mil-011-plan.md @@ -9,7 +9,7 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version; accepted by the author in chat as stand-in for S01, after three corrections found in the first read | pending | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Initial version; accepted by the author in chat as stand-in for S01, after three corrections found in the first read | [3d7a9df] | --- @@ -64,3 +64,4 @@ Go - all criteria pass after three corrections found in the first read (the O5 w [ADR-0006]: ../../adr/adr-0006-release-process-and-version-pinning.md [RC-068]: ./rc-068-mil-010-plan.md [QC-MIL-001]: ../../../framework/qc/artifacts/qc-milestones-gateways.md +[3d7a9df]: https://git.tirsystem.com/TirSystem/github-action/commit/3d7a9df3a3a4712dcc5214a71b0569d90122bf4e diff --git a/docs/sqa/traceability-matrix.md b/docs/sqa/traceability-matrix.md index 072fdb9..02e3190 100644 --- a/docs/sqa/traceability-matrix.md +++ b/docs/sqa/traceability-matrix.md @@ -10,7 +10,7 @@ | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | | 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-075 (MIL-010 outcome, release 2.1.0) | [aa20e56] | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-011 and RC-076 (fix the defaults of the code metrics workflow) | pending | +| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-011 and RC-076 (fix the defaults of the code metrics workflow) | [3d7a9df] | --- @@ -255,3 +255,4 @@ updated whenever an artifact instance is created or reviewed. [UC-005]: ../uc-005/uc.md [ADR-0005]: ../adr/adr-0005-quality-check-contract.md [aa20e56]: https://git.tirsystem.com/TirSystem/github-action/commit/aa20e56110f4c2fab91a8432ba008ee8300926a2 +[3d7a9df]: https://git.tirsystem.com/TirSystem/github-action/commit/3d7a9df3a3a4712dcc5214a71b0569d90122bf4e -- 2.54.0