The shell of the reusable quality-checks workflow moves to tools/quality-checks.sh; quality-checks.yml shrinks from about 150 to 74 lines and embeds no script.
tools/quality-checks.sh validate|install|run: the three steps unchanged in behavior and messages.
quality-checks.yml: checks out the caller, fetches the script into shared-scripts/ at the new input tools-ref (default v1) and runs it.
Why an input: a called workflow cannot learn its own ref on this instance (workflow_ref, workflow_sha, job_workflow_sha, action_ref are empty; verified on a throwaway branch). A call at an exact tag is pinned completely only with tools-ref set to the same tag; documented in the guide and the upgrade guide.
Tests run the script file with the same stub tools; new tests for the input, the fetch step and the unknown command. 238 pass.
ADR-0005 notes the input (RC-051); changelog entry for 1.1.0 (a new optional input is a minor change).
Trial: RepoFoundry throwaway branch calling this branch with tools-ref set to it, run 663 passed (shellcheck and shfmt); the branch is deleted.
Wiki pages changed: QualityChecksPythonShell and Upgrading (en, da, ms).
Order matters: on main the default tools-ref: v1 points to 1.0.1, which has no script yet, so a caller at @main (RepoFoundry today) fails until 1.1.0 is released right after this merge.
The shell of the reusable quality-checks workflow moves to `tools/quality-checks.sh`; `quality-checks.yml` shrinks from about 150 to 74 lines and embeds no script.
- `tools/quality-checks.sh validate|install|run`: the three steps unchanged in behavior and messages.
- `quality-checks.yml`: checks out the caller, fetches the script into `shared-scripts/` at the new input `tools-ref` (default `v1`) and runs it.
- Why an input: a called workflow cannot learn its own ref on this instance (`workflow_ref`, `workflow_sha`, `job_workflow_sha`, `action_ref` are empty; verified on a throwaway branch). A call at an exact tag is pinned completely only with `tools-ref` set to the same tag; documented in the guide and the upgrade guide.
- Tests run the script file with the same stub tools; new tests for the input, the fetch step and the unknown command. 238 pass.
- ADR-0005 notes the input (RC-051); changelog entry for `1.1.0` (a new optional input is a minor change).
- Trial: RepoFoundry throwaway branch calling this branch with `tools-ref` set to it, run 663 passed (shellcheck and shfmt); the branch is deleted.
Wiki pages changed: QualityChecksPythonShell and Upgrading (en, da, ms).
Order matters: on `main` the default `tools-ref: v1` points to `1.0.1`, which has no script yet, so a caller at `@main` (RepoFoundry today) fails until `1.1.0` is released right after this merge.
Refs #24
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The shell of the reusable quality-checks workflow moves to
tools/quality-checks.sh;quality-checks.ymlshrinks from about 150 to 74 lines and embeds no script.tools/quality-checks.sh validate|install|run: the three steps unchanged in behavior and messages.quality-checks.yml: checks out the caller, fetches the script intoshared-scripts/at the new inputtools-ref(defaultv1) and runs it.workflow_ref,workflow_sha,job_workflow_sha,action_refare empty; verified on a throwaway branch). A call at an exact tag is pinned completely only withtools-refset to the same tag; documented in the guide and the upgrade guide.1.1.0(a new optional input is a minor change).tools-refset to it, run 663 passed (shellcheck and shfmt); the branch is deleted.Wiki pages changed: QualityChecksPythonShell and Upgrading (en, da, ms).
Order matters: on
mainthe defaulttools-ref: v1points to1.0.1, which has no script yet, so a caller at@main(RepoFoundry today) fails until1.1.0is released right after this merge.Refs #24