Record that reusable workflows work on the instance (MIL-003 task 1) #67

Merged
Tirsvad merged 2 commits from mil-003-reusable-workflows-verified into main 2026-10-10 07:33:46 +02:00
Owner

Records the result of MIL-003 task 1 (issue #15): reusable workflows work on the instance.

Verification (2026-10-10, Gitea 1.27.3)

Throwaway branches verify-reusable-workflows (all deleted afterwards). A called workflow declared on: workflow_call with one input and printed it; callers used jobs.<job_id>.uses.

Call Caller Result
uses: ./.gitea/workflows/reuse-callee.yml TirSystem/github-action ran, input received
uses: TirSystem/github-action/.gitea/workflows/reuse-callee.yml@<branch> TirSystem/github-action ran, input received
the same TirSystem/sqa-qc-checklists (same organization) ran; gitea.repository was the caller
the same TirSystem-BashScript/RepoFoundry (another organization) ran; gitea.repository was the caller

Conclusion: no copied-template fallback is needed for MIL-003.

Not covered

A private provider repository (the provider here is public), passing secrets to a called workflow (secrets: or secrets: inherit), and a reference by tag. The quality checks need none of the secrets; the RC-033 action item (S05, 2026-11-28) asks for these before MIL-004 relies on them.

Changes

  • docs/milestones/mil-003-quality-checks.md: a "Verification results" section, task 1 marked verified, a new Accepted version row.
  • docs/sqa/reviews/rc-033-mil-003-reusable-workflows.md: review record (QC-MIL-001, Go; S01 standing in as ADR-0002 records).
  • TM-001 and the registry updated (next RC 034). No wiki pages changed.

About the Docker idea

A local container would not answer this: workflow_call and uses are resolved by this instance's server and runner, so the test had to run on the instance.

Closes #15

Records the result of MIL-003 task 1 (issue #15): reusable workflows work on the instance. ## Verification (2026-10-10, Gitea 1.27.3) Throwaway branches `verify-reusable-workflows` (all deleted afterwards). A called workflow declared `on: workflow_call` with one input and printed it; callers used `jobs.<job_id>.uses`. | Call | Caller | Result | | --- | --- | --- | | `uses: ./.gitea/workflows/reuse-callee.yml` | `TirSystem/github-action` | ran, input received | | `uses: TirSystem/github-action/.gitea/workflows/reuse-callee.yml@<branch>` | `TirSystem/github-action` | ran, input received | | the same | `TirSystem/sqa-qc-checklists` (same organization) | ran; `gitea.repository` was the caller | | the same | `TirSystem-BashScript/RepoFoundry` (another organization) | ran; `gitea.repository` was the caller | Conclusion: no copied-template fallback is needed for MIL-003. ## Not covered A private provider repository (the provider here is public), passing secrets to a called workflow (`secrets:` or `secrets: inherit`), and a reference by tag. The quality checks need none of the secrets; the RC-033 action item (S05, 2026-11-28) asks for these before MIL-004 relies on them. ## Changes - `docs/milestones/mil-003-quality-checks.md`: a "Verification results" section, task 1 marked verified, a new `Accepted` version row. - `docs/sqa/reviews/rc-033-mil-003-reusable-workflows.md`: review record (QC-MIL-001, Go; S01 standing in as ADR-0002 records). - TM-001 and the registry updated (next RC 034). No wiki pages changed. ## About the Docker idea A local container would not answer this: `workflow_call` and `uses` are resolved by this instance's server and runner, so the test had to run on the instance. Closes #15
Tirsvad added 2 commits 2026-10-10 07:32:46 +02:00
Verified on 2026-10-10 with throwaway branches (deleted afterwards):
workflow_call and uses run from the same repository, another repository of
the organisation and a repository of another organisation, so MIL-003 needs
no copied-template fallback. Not tested: a private provider, secrets passed
to a called workflow, and a tag reference. Review it (RC-033) and update
TM-001.

Task: MIL-003#1
Resolve pending commit links in MIL-003, RC-033 and TM-001
Validate workflows / validate (pull_request) Successful in 14s
f8879fcf06
Tirsvad merged commit da53cceb7c into main 2026-10-10 07:33:46 +02:00
Tirsvad deleted branch mil-003-reusable-workflows-verified 2026-10-10 07:33:47 +02:00
Sign in to join this conversation.