ADR-0009 and RC-063: review and acceptance #139

Merged
Tirsvad merged 3 commits from review-adr-0009 into main 2026-10-13 17:33:55 +02:00
Owner

What

Reviews ADR-0009 (wiki publishing as a reusable workflow) against QC-ADR-001 and accepts it.

  • docs/sqa/reviews/rc-063-adr-0009.md: all applicable criteria pass; three findings were fixed during the review.
  • docs/adr/adr-0009-wiki-publishing-reusable-workflow.md: the findings fixed in a new Version History row, then Accepted; the first row becomes Deprecated.
  • docs/sqa/traceability-matrix.md: ADR-0009 and RC-063 rows and cross references.

Findings fixed in the ADR

Criterion Finding Fix
5 "Passing a declared secret is not yet verified" was out of date; run 316 verified it on 2026-10-13 Now states it is verified, with the local uses: call
6 The security impact was implicit A positive bullet (explicit secret, no fallback) and a negative one (whoever changes the caller changes the folder and prune)
10 "PO language" is an unexplained abbreviation "the product owner's language"

Criterion 9 is N-A: ADR-0004 is superseded only in part and stays in force until the scoped workflow is removed (action item for the follow-up milestone).

Status

S01 gave the Go in chat on 2026-10-13. Docs only; closes no issue. The earlier commits of the branch (PP-001 and RC-062 acceptance) are already on main through #138.

Open

The 7 task issues of milestone MIL-008 are still open on the host; the follow-up milestone (migrate 8 repositories, remove the scoped workflow) has no plan yet.

## What Reviews **ADR-0009** (wiki publishing as a reusable workflow) against `QC-ADR-001` and accepts it. - `docs/sqa/reviews/rc-063-adr-0009.md`: all applicable criteria pass; three findings were fixed during the review. - `docs/adr/adr-0009-wiki-publishing-reusable-workflow.md`: the findings fixed in a new Version History row, then `Accepted`; the first row becomes `Deprecated`. - `docs/sqa/traceability-matrix.md`: ADR-0009 and RC-063 rows and cross references. ## Findings fixed in the ADR | Criterion | Finding | Fix | | --- | --- | --- | | 5 | "Passing a declared secret is not yet verified" was out of date; run 316 verified it on 2026-10-13 | Now states it is verified, with the local `uses:` call | | 6 | The security impact was implicit | A positive bullet (explicit secret, no fallback) and a negative one (whoever changes the caller changes the folder and `prune`) | | 10 | "PO language" is an unexplained abbreviation | "the product owner's language" | Criterion 9 is N-A: ADR-0004 is superseded only in part and stays in force until the scoped workflow is removed (action item for the follow-up milestone). ## Status S01 gave the Go in chat on 2026-10-13. Docs only; closes no issue. The earlier commits of the branch (PP-001 and RC-062 acceptance) are already on `main` through #138. ## Open The 7 task issues of milestone MIL-008 are still open on the host; the follow-up milestone (migrate 8 repositories, remove the scoped workflow) has no plan yet.
Tirsvad added 3 commits 2026-10-13 17:33:22 +02:00
RC-063 reviews ADR-0009 against QC-ADR-001: three findings fixed (stale
verification statement, security impact named, product owner spelled out).
S01 gave the Go in chat on 2026-10-13; ADR-0009 and RC-063 are Accepted.
Resolve pending commit link of RC-063
TirSystem/github-action: Publish wiki / publish-wiki (push) Skipped
TirSystem/github-action: Sync GitHub mirror metadata / sync-metadata (push) Skipped
Validate workflows / validate (pull_request) Successful in 24s
8c0f006dc5
Tirsvad merged commit 157bf6560d into main 2026-10-13 17:33:55 +02:00
Tirsvad deleted branch review-adr-0009 2026-10-13 17:33:55 +02:00
Sign in to join this conversation.