Draft ADR-0008 for C++ and C# quality checks (MIL-007 task 3) #105

Merged
Tirsvad merged 4 commits from mil-007-sdk-10-and-adr into main 2026-10-11 06:42:40 +02:00
Owner

MIL-007 task 3 (#97): draft of the contract ADR, with the decisions S01 gave on 2026-10-11 and the amendment that did not reach main with PR 103.

  • Amendment (cherry-picked from the branch of PR 103, which was merged before these two commits): current tool versions only and .NET SDK 10 or later in MIL-007 (deliverable, criterion 1, task 3, results of run 699).
  • ADR-0008 (Proposed): two separate reusable workflows, quality-checks-cpp.yml (C and C++) and quality-checks-csharp.yml, each running a script file fetched at tools-ref; cppcheck is not used (only an old version is available; clang-tidy does the static analysis); every tool and the SDK are pinned at exact versions (clang-format 23.1.3, clang-tidy 22.1.8, .NET SDK 10.0.x via dotnet-install.sh --version); the contract of ADR-0005 for pass, fail and logs is unchanged. Inputs, names and consequences are in the document.

Choices in the draft that S01 should confirm or change:

  1. One workflow per language (my recommendation; the alternative is one combined workflow).
  2. C is included with C++ (the same tools, told apart by extension).
  3. The inputs std, compile-commands-dir, project and the default c++20.

Needs the review and acceptance of ADR-0008 (RC record follows) before tasks 4 and 5 (#98, #99) may start; the plan-first gate stops there.

No wiki pages changed.

Refs #97

MIL-007 task 3 (#97): draft of the contract ADR, with the decisions S01 gave on 2026-10-11 and the amendment that did not reach `main` with PR 103. - **Amendment (cherry-picked from the branch of PR 103, which was merged before these two commits):** current tool versions only and .NET SDK 10 or later in MIL-007 (deliverable, criterion 1, task 3, results of run 699). - **ADR-0008 (Proposed):** two separate reusable workflows, `quality-checks-cpp.yml` (C and C++) and `quality-checks-csharp.yml`, each running a script file fetched at `tools-ref`; `cppcheck` is not used (only an old version is available; `clang-tidy` does the static analysis); every tool and the SDK are pinned at exact versions (`clang-format` 23.1.3, `clang-tidy` 22.1.8, .NET SDK 10.0.x via `dotnet-install.sh --version`); the contract of ADR-0005 for pass, fail and logs is unchanged. Inputs, names and consequences are in the document. Choices in the draft that S01 should confirm or change: 1. One workflow per language (my recommendation; the alternative is one combined workflow). 2. C is included with C++ (the same tools, told apart by extension). 3. The inputs `std`, `compile-commands-dir`, `project` and the default `c++20`. Needs the review and acceptance of ADR-0008 (RC record follows) before tasks 4 and 5 (#98, #99) may start; the plan-first gate stops there. No wiki pages changed. Refs #97
Tirsvad added 4 commits 2026-10-11 06:40:11 +02:00
Resolve pending commit links in ADR-0008
TirSystem/github-action: Publish wiki / publish-wiki (push) Skipped
TirSystem/github-action: Sync GitHub mirror metadata / sync-metadata (push) Skipped
Validate workflows / validate (pull_request) Successful in 19s
fb1fafc5c5
Tirsvad merged commit c5f189c6cc into main 2026-10-11 06:42:40 +02:00
Tirsvad deleted branch mil-007-sdk-10-and-adr 2026-10-11 06:42:40 +02:00
Sign in to join this conversation.