MIL-011 tasks 2 to 4: the default tools-ref is the current major
TirSystem/github-action: Sync GitHub mirror metadata / sync-metadata (push) Skipped
TirSystem/github-action: Sync GitHub mirror metadata / sync-metadata (push) Skipped
code-metrics.yml defaulted tools-ref to v1 and its guide said @v1, but the workflow and its scripts exist only from v2.1.0. The default of the five reusable workflows is now the current major, defined once in MAJOR_TAG, and tests/test_tools_ref.py fails when a default differs from it or names a tag without the script. Guides, README and wiki (en, da, ms) call code-metrics.yml at @v2; ADR-0005, 0008, 0009 and 0010 carry an amendment; RC-077 accepts the milestone's task 1 results. Task: MIL-011#2
This commit is contained in:
@@ -9,8 +9,8 @@
|
||||
## Version History
|
||||
| Date | Status | Author | Reviewer | Change | Commit |
|
||||
| --- | --- | --- | --- | --- | --- |
|
||||
| 2026-10-10 | Deprecated | Jens Tirsvad Nielsen | S01 | Reviewed (RC-038): the security impact of installing the tools from PyPI named | [385d2fb] |
|
||||
| 2026-10-11 | Accepted | Jens Tirsvad Nielsen | S01 | Added the input tools-ref: the shell steps moved to a script file fetched at that ref (RC-051) | [670f0ac] |
|
||||
| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Amendment: the default `tools-ref` is the current major tag (MIL-011) | pending |
|
||||
|
||||
Allowed Status values: `Proposed`, `Accepted`, `Rejected`, `Deprecated`, `Superseded by ADR-NNNN`.
|
||||
|
||||
@@ -118,6 +118,14 @@ The rules that follow from it:
|
||||
- [ADR-0004] — the same pattern of a shared scoped or reusable workflow with an
|
||||
explicit gate; this ADR does not change it.
|
||||
|
||||
|
||||
## Amendment (MIL-011)
|
||||
|
||||
The default of the input `tools-ref` in the quality-check contract is the current major tag, defined once in the file
|
||||
`MAJOR_TAG` of this repository (`v2` from release 2.1.1), and no longer `v1`. A default must
|
||||
name a tag that holds the script the workflow runs; a test checks it. Callers at `@v1` are
|
||||
not affected: the `v1` tag keeps the `v1` workflow files.
|
||||
|
||||
---
|
||||
|
||||
[MIL-003]: ../milestones/mil-003-quality-checks.md
|
||||
|
||||
Reference in New Issue
Block a user