MIL-011 tasks 2 to 4: the default tools-ref is the current major

code-metrics.yml defaulted tools-ref to v1 and its guide said @v1, but the workflow and its scripts exist only from v2.1.0. The default of the five reusable workflows is now the current major, defined once in MAJOR_TAG, and tests/test_tools_ref.py fails when a default differs from it or names a tag without the script. Guides, README and wiki (en, da, ms) call code-metrics.yml at @v2; ADR-0005, 0008, 0009 and 0010 carry an amendment; RC-077 accepts the milestone's task 1 results. Task: MIL-011#2
2026-10-14 17:09:34 +08:00
parent 76f6b56f8d
commit eaa0e30bea
42 changed files with 264 additions and 62 deletions
@@ -9,8 +9,8 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-10 | Deprecated | Jens Tirsvad Nielsen | S01 | Reviewed (RC-038): the security impact of installing the tools from PyPI named | [385d2fb] |
 | 2026-10-11 | Accepted | Jens Tirsvad Nielsen | S01 | Added the input tools-ref: the shell steps moved to a script file fetched at that ref (RC-051) | [670f0ac] |
+| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Amendment: the default `tools-ref` is the current major tag (MIL-011) | pending |

 Allowed Status values: `Proposed`, `Accepted`, `Rejected`, `Deprecated`, `Superseded by ADR-NNNN`.

@@ -118,6 +118,14 @@ The rules that follow from it:
 - [ADR-0004] — the same pattern of a shared scoped or reusable workflow with an
  explicit gate; this ADR does not change it.

+
+## Amendment (MIL-011)
+
+The default of the input `tools-ref` in the quality-check contract is the current major tag, defined once in the file
+`MAJOR_TAG` of this repository (`v2` from release 2.1.1), and no longer `v1`. A default must
+name a tag that holds the script the workflow runs; a test checks it. Callers at `@v1` are
+not affected: the `v1` tag keeps the `v1` workflow files.
+
 ---

 [MIL-003]: ../milestones/mil-003-quality-checks.md
@@ -9,8 +9,8 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-11 | Deprecated | Jens Tirsvad Nielsen | S01 | Initial version | [11cba35] |
 | 2026-10-11 | Accepted | Jens Tirsvad Nielsen | S01 | Reviewed (RC-054): abbreviations expanded at first use and the security impact of downloading tools named | [9e7aedd] |
+| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Amendment: the default `tools-ref` is the current major tag (MIL-011) | pending |

 Allowed Status values: `Proposed`, `Accepted`, `Rejected`, `Deprecated`, `Superseded by ADR-NNNN`.

@@ -134,6 +134,14 @@ The rules that follow from it:
 - [ADR-0005] — the contract that this decision extends, unchanged.
 - [ADR-0006] — raising a default tool version is breaking.

+
+## Amendment (MIL-011)
+
+The default of the input `tools-ref` in the C++ and C# quality-check contract is the current major tag, defined once in the file
+`MAJOR_TAG` of this repository (`v2` from release 2.1.1), and no longer `v1`. A default must
+name a tag that holds the script the workflow runs; a test checks it. Callers at `@v1` are
+not affected: the `v1` tag keeps the `v1` workflow files.
+
 ---

 [MIL-007]: ../milestones/mil-007-cpp-csharp-quality-checks.md
@@ -9,8 +9,8 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-13 | Deprecated | Jens Tirsvad Nielsen | S01 | Initial version | [01b9c29] |
 | 2026-10-13 | Accepted | Jens Tirsvad Nielsen | S01 | Review findings fixed (RC-063): the product owner's language is spelled out, the security consequence is named, and the secret passing is recorded as verified | [8c2c52e] |
+| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Amendment: the default `tools-ref` is the current major tag (MIL-011) | pending |

 Allowed Status values: `Proposed`, `Accepted`, `Rejected`, `Deprecated`, `Superseded by ADR-NNNN`.

@@ -93,6 +93,14 @@ The rules that follow from it:
 - [ADR-0004] — its scoped delivery and marker parts are replaced once the
  scoped workflow is removed; its token and safety rules stand.

+
+## Amendment (MIL-011)
+
+The default of the input `tools-ref` in the wiki publishing contract is the current major tag, defined once in the file
+`MAJOR_TAG` of this repository (`v2` from release 2.1.1), and no longer `v1`. A default must
+name a tag that holds the script the workflow runs; a test checks it. Callers at `@v1` are
+not affected: the `v1` tag keeps the `v1` workflow files.
+
 ---

 [MIL-008]: ../milestones/mil-008-wiki-reusable-workflow.md
@@ -9,8 +9,8 @@
 ## Version History
 | Date | Status | Author | Reviewer | Change | Commit |
 | --- | --- | --- | --- | --- | --- |
-| 2026-10-14 | Deprecated | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version; reviewed (RC-072) | [0dc5132] |
 | 2026-10-14 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | The report reaches the workflow as an artifact of the caller's run (input `coverage-artifact`), because a called workflow runs in its own job; reviewed (RC-073) | [0dc5132] |
+| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Amendment: the default `tools-ref` is the current major tag (MIL-011) | pending |

 Allowed Status values: `Proposed`, `Accepted`, `Rejected`, `Deprecated`, `Superseded by ADR-NNNN`.

@@ -207,6 +207,14 @@ The rules that follow from it:
 - [ADR-0006] — adding a language, or changing a colour or a default, is a
  release under its rules; raising a default threshold is breaking.

+
+## Amendment (MIL-011)
+
+The default of the input `tools-ref` in the code metrics contract is the current major tag, defined once in the file
+`MAJOR_TAG` of this repository (`v2` from release 2.1.1), and no longer `v1`. A default must
+name a tag that holds the script the workflow runs; a test checks it. Callers at `@v1` are
+not affected: the `v1` tag keeps the `v1` workflow files.
+
 ---

 [MIL-010]: ../milestones/mil-010-code-metrics-badges.md