From 4aa3fd38f97c26a5d52abc566e958759583ccb85 Mon Sep 17 00:00:00 2001 From: Jens Tirsvad Nielsen Date: Wed, 14 Oct 2026 17:30:48 +0800 Subject: [PATCH 1/2] MIL-011 outcome: release 2.1.1 and the framework page, RC-079 The Release workflow created v2.1.1 and moved v2 (v1 unchanged); a call at @v2 with the defaults ran after the release (run 1526). The framework Badges page has no tools-ref workaround (framework pull request 57). RC-079: Go, all eight criteria pass. --- docs/artifact-registry.md | 2 +- .../mil-011-code-metrics-default-tools-ref.md | 12 ++++- docs/sqa/reviews/rc-079-mil-011-outcome.md | 49 +++++++++++++++++++ docs/sqa/traceability-matrix.md | 6 ++- 4 files changed, 64 insertions(+), 5 deletions(-) create mode 100644 docs/sqa/reviews/rc-079-mil-011-outcome.md diff --git a/docs/artifact-registry.md b/docs/artifact-registry.md index 328704f..23d387b 100644 --- a/docs/artifact-registry.md +++ b/docs/artifact-registry.md @@ -11,7 +11,7 @@ each document lives in *this* project and the next version to use. | SA | Stakeholder Analysis | docs/stakeholder-analysis.md | 002 | | PP | Project Plan | docs/project-plan.md | 002 | | MIL | Milestone / Gateway | docs/milestones/*.md | 012 | -| RC | SQA Review Record | docs/sqa/reviews/rc-*.md | 079 | +| RC | SQA Review Record | docs/sqa/reviews/rc-*.md | 080 | | TM | Traceability Matrix | docs/sqa/traceability-matrix.md | 002 | | ADR | Architecture Decision Record | docs/adr/adr-NNNN-*.md | 0011 | | UCD | Use Case Diagram | docs/use-case-diagram.md | 002 | diff --git a/docs/milestones/mil-011-code-metrics-default-tools-ref.md b/docs/milestones/mil-011-code-metrics-default-tools-ref.md index ace9424..b2a438b 100644 --- a/docs/milestones/mil-011-code-metrics-default-tools-ref.md +++ b/docs/milestones/mil-011-code-metrics-default-tools-ref.md @@ -9,8 +9,8 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Added the results of task 1 (reproduction and the defaults of the five workflows); reviewed (RC-077), accepted by the AI as stand-in for S01 in autonomous mode | [e11c43f] | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added the results of tasks 2 to 5 (the fix, the test, the guides, the run on the instance); reviewed in RC-078, the release follows | [a6892c3] | +| 2026-10-14 | Deprecated | Jens Tirsvad Nielsen | S01 | Added the results of task 1 (reproduction and the defaults of the five workflows); reviewed (RC-077), accepted by the AI as stand-in for S01 in autonomous mode | [e11c43f] | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | S01 | Added the results of tasks 2 to 5 (the fix, the test, the guides, the run on the instance); reviewed in RC-078, the release follows; outcome reviewed (RC-079), accepted by the AI as stand-in for S01 in autonomous mode | [a6892c3] | --- @@ -107,6 +107,13 @@ Tasks 2 to 5 were done on 2026-10-14 on the branch `mil-011-fix`: - **Guides (task 4):** `guides/code-metrics.md`, `guides/upgrading.md`, the three quality-check guides, `README.md` and the wiki pages in English, Danish and Bahasa Malaysia; the amendments of ADR-0005, ADR-0008, ADR-0009 and ADR-0010. A search for `code-metrics.yml@v1` finds none. - **Instance (task 5):** the workflow at `@mil-011-fix` with every input at its default except `badges-branch` ran as run 1509 (job 1649): `tools-ref` resolved to `v2`, the scripts were fetched, and the badges were committed to `badges-verify` (commit `041d991`). + +Tasks 6 and 7 were done on 2026-10-14: + +- **Release (task 6):** the Release workflow ran in dry-run mode (run 1524) and then for real (run 1525); `v2.1.1` and `v2` are `3023461`, `v1` is unchanged at `9bf0a2b` (1.2.2), and the release page has the changelog entry. A call at `@v2` with the defaults ran after the release (run 1526, job 1670): `tools-ref` resolved to `v2`, the scripts were fetched at `3023461`, and the badges were published. +- **Framework page (task 7):** `TirSystem/sqa-qc-framework` pull request 57 removed the `tools-ref` workaround from the `Badges` pages in three languages; the wiki is published. +- **Outcome:** [RC-079], Go, all eight criteria pass. + --- [BC-001]: ../business-case.md @@ -115,5 +122,6 @@ Tasks 2 to 5 were done on 2026-10-14 on the branch `mil-011-fix`: [ADR-0010]: ../adr/adr-0010-code-metrics-badges-contract.md [ADR-0006]: ../adr/adr-0006-release-process-and-version-pinning.md [PP-001]: ../project-plan.md +[RC-079]: ../sqa/reviews/rc-079-mil-011-outcome.md [e11c43f]: https://git.tirsystem.com/TirSystem/github-action/commit/e11c43f0a41e7dd9647f7804947d6e464407a597 [a6892c3]: https://git.tirsystem.com/TirSystem/github-action/commit/a6892c372aca9f2e12826a4c3b260290a0656ecb diff --git a/docs/sqa/reviews/rc-079-mil-011-outcome.md b/docs/sqa/reviews/rc-079-mil-011-outcome.md new file mode 100644 index 0000000..20de406 --- /dev/null +++ b/docs/sqa/reviews/rc-079-mil-011-outcome.md @@ -0,0 +1,49 @@ +# Review Record: MIL-011 outcome (release 2.1.1) + +## Metadata +| Key | Value | +| --- | --- | +| ID | RC-079 | +| CrossReference | [MIL-011], [RC-078] | + +## Version History +| Date | Status | Author | Reviewer | Change | Commit | +| --- | --- | --- | --- | --- | --- | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version; Go; accepted by the AI as stand-in for S01 in autonomous mode, not independent | pending | + +--- + +## Artifact Under Review + +- Instance reviewed: the outcome of [MIL-011]: the release `v2.1.1` of this repository (tag on `3023461`, the release page, the moving major tag `v2`) and the framework `Badges` page (`TirSystem/sqa-qc-framework` pull request 57) +- Checklist used: the eight Go/No-Go criteria of [MIL-011]; criteria 1 to 5 were scored in [RC-078] and are not repeated +- Scope: re-score of criteria 6, 7 and 8, after the release +- Language and domain: n/a (technical type) +- Mode: autonomous, not independent (the reviewer is `AI as stand-in for S01`) + +## Checklist Results + +| # | Criterion | Status | Evidence/Notes | +| --- | --- | --- | --- | +| 1 to 5 | See [RC-078] | Pass | Reproduced (run 1499), every default checked, the default derived from `MAJOR_TAG` with a failing seeded test, no `@v1` for `code-metrics.yml`, a run on the instance (run 1509). | +| 6 | The release is a patch (2.1.1); `v2` moves to it, `v1` is untouched | Pass | The Release workflow ran in dry-run mode (run 1524: "Checks passed for v2.1.1 on 3023461 ... would create the release page v2.1.1 and point v2 to it") and then for real (run 1525). `git ls-remote`: `v2.1.1` and `v2` (peeled) are `3023461`; `v1` is `1.2.2` (`9bf0a2b`), unchanged. The release page has the changelog entry as its text. After the release a call at `@v2` with the defaults ran on the instance (run 1526, job 1670): `tools-ref: v2`, the scripts fetched at `3023461`, badges published to `badges-verify`. | +| 7 | The framework `Badges` page no longer tells a caller to set `tools-ref` | Pass | `TirSystem/sqa-qc-framework` pull request 57 is merged and the wiki is published: the three pages have no `tools-ref: v2` line and no bullet about it, call the workflow at `@v2`, and say to use 2.1.1 or later, not 2.1.0. | +| 8 | Reviewed | Pass | [RC-076], [RC-077], [RC-078] and this record, each with a verdict of Go; [MIL-011] and its plan row are `Accepted`. | + +## Overall Verdict + +Go - all eight criteria pass. The defect is fixed in release 2.1.1: the default `tools-ref` of the five reusable workflows is the current major (`MAJOR_TAG`), a test keeps it so, and a call at `@v2` with the defaults runs. Two things stay as they are and are reported, not decided here: release `2.1.0` still has the defect (a release tag is never moved, ADR-0006) and callers are told to use 2.1.1 or later; and the other four workflows now fetch their scripts from the current major instead of `1.2.2`, which changes no behaviour for a caller at `@v1`. The AI accepts the record as stand-in for S01 in autonomous mode; there is no independent reader and the decision stays open to challenge in the run summary. + +## Action Items + +| Action | Owner | Due | +| --- | --- | --- | +| Delete the throwaway branch `verify-code-metrics-defaults` when the evidence is no longer needed (a branch deletion is left to a person) | S05 | 2026-10-23 | +| Decide whether the required status check `Sync GitHub mirror metadata / sync-metadata (push)` should stay required on pull requests, where it is only `skipped` and blocks a merge through the API | S05 | 2026-10-30 | + +--- + +[MIL-011]: ../../milestones/mil-011-code-metrics-default-tools-ref.md +[RC-078]: ./rc-078-mil-011-fix.md +[RC-076]: ./rc-076-mil-011-plan.md +[RC-077]: ./rc-077-mil-011-task-1-results.md diff --git a/docs/sqa/traceability-matrix.md b/docs/sqa/traceability-matrix.md index e1200ae..5f7c75e 100644 --- a/docs/sqa/traceability-matrix.md +++ b/docs/sqa/traceability-matrix.md @@ -9,8 +9,8 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added MIL-011 and RC-076 (fix the defaults of the code metrics workflow) | [3d7a9df] | | 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-077 and RC-078 (MIL-011 task 1 results, and the fix of the defaults) | [a6892c3] | +| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-079 (MIL-011 outcome, release 2.1.1) | pending | --- @@ -44,7 +44,7 @@ updated whenever an artifact instance is created or reviewed. | [MIL-008] | MIL | [BC-001], [PP-001], [MIL-006], [ADR-0004] | [MIL-009] | [RC-060], [RC-061] | | [MIL-009] | MIL | [BC-001], [PP-001], [MIL-008], [ADR-0004], [ADR-0006], [ADR-0009] | - | [RC-064], [RC-066] | | [MIL-010] | MIL | [BC-001], [PP-001], [MIL-003], [MIL-004] | [MIL-011] | [RC-068], [RC-074], [RC-075] | -| [MIL-011] | MIL | [BC-001], [PP-001], [MIL-010], [ADR-0006], [ADR-0010] | - | [RC-076], [RC-077], [RC-078] | +| [MIL-011] | MIL | [BC-001], [PP-001], [MIL-010], [ADR-0006], [ADR-0010] | - | [RC-076], [RC-077], [RC-078], [RC-079] | | [RC-007] | RC | [MIL-004] | - | - | | [RC-008] | RC | [BC-001] | - | - | | [RC-009] | RC | [PP-001] | - | - | @@ -136,6 +136,7 @@ updated whenever an artifact instance is created or reviewed. | [RC-076] | RC | [MIL-011], [PP-001] | - | - | | [RC-077] | RC | [MIL-011] | - | - | | [RC-078] | RC | [MIL-011] | - | - | +| [RC-079] | RC | [MIL-011] | - | - | ## Coverage Notes @@ -249,6 +250,7 @@ updated whenever an artifact instance is created or reviewed. [RC-076]: ./reviews/rc-076-mil-011-plan.md [RC-077]: ./reviews/rc-077-mil-011-task-1-results.md [RC-078]: ./reviews/rc-078-mil-011-fix.md +[RC-079]: ./reviews/rc-079-mil-011-outcome.md [ADR-0008]: ../adr/adr-0008-cpp-csharp-quality-check-contract.md [ADR-0009]: ../adr/adr-0009-wiki-publishing-reusable-workflow.md [ADR-0007]: ../adr/adr-0007-release-publish-destination.md From 251e18dfc3105c8cf0851d7474f2adbce285aba9 Mon Sep 17 00:00:00 2001 From: Jens Tirsvad Nielsen Date: Wed, 14 Oct 2026 17:30:49 +0800 Subject: [PATCH 2/2] Resolve pending commit links for RC-079 --- docs/sqa/reviews/rc-079-mil-011-outcome.md | 3 ++- docs/sqa/traceability-matrix.md | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/sqa/reviews/rc-079-mil-011-outcome.md b/docs/sqa/reviews/rc-079-mil-011-outcome.md index 20de406..b0a8064 100644 --- a/docs/sqa/reviews/rc-079-mil-011-outcome.md +++ b/docs/sqa/reviews/rc-079-mil-011-outcome.md @@ -9,7 +9,7 @@ ## Version History | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | -| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version; Go; accepted by the AI as stand-in for S01 in autonomous mode, not independent | pending | +| 2026-10-14 | Accepted | Jens Tirsvad Nielsen | AI as stand-in for S01 | Initial version; Go; accepted by the AI as stand-in for S01 in autonomous mode, not independent | [4aa3fd3] | --- @@ -47,3 +47,4 @@ Go - all eight criteria pass. The defect is fixed in release 2.1.1: the default [RC-078]: ./rc-078-mil-011-fix.md [RC-076]: ./rc-076-mil-011-plan.md [RC-077]: ./rc-077-mil-011-task-1-results.md +[4aa3fd3]: https://git.tirsystem.com/TirSystem/github-action/commit/4aa3fd38f97c26a5d52abc566e958759583ccb85 diff --git a/docs/sqa/traceability-matrix.md b/docs/sqa/traceability-matrix.md index 5f7c75e..eb0e27f 100644 --- a/docs/sqa/traceability-matrix.md +++ b/docs/sqa/traceability-matrix.md @@ -10,7 +10,7 @@ | Date | Status | Author | Reviewer | Change | Commit | | --- | --- | --- | --- | --- | --- | | 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-077 and RC-078 (MIL-011 task 1 results, and the fix of the defaults) | [a6892c3] | -| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-079 (MIL-011 outcome, release 2.1.1) | pending | +| 2026-10-14 | Proposed | Jens Tirsvad Nielsen | S01 | Added RC-079 (MIL-011 outcome, release 2.1.1) | [4aa3fd3] | --- @@ -262,3 +262,4 @@ updated whenever an artifact instance is created or reviewed. [ADR-0005]: ../adr/adr-0005-quality-check-contract.md [3d7a9df]: https://git.tirsystem.com/TirSystem/github-action/commit/3d7a9df3a3a4712dcc5214a71b0569d90122bf4e [a6892c3]: https://git.tirsystem.com/TirSystem/github-action/commit/a6892c372aca9f2e12826a4c3b260290a0656ecb +[4aa3fd3]: https://git.tirsystem.com/TirSystem/github-action/commit/4aa3fd38f97c26a5d52abc566e958759583ccb85