From 4560a7e9a0c62239d2a9aaf36c082680001c7e0b Mon Sep 17 00:00:00 2001 From: Jens Tirsvad Nielsen Date: Tue, 13 Oct 2026 18:01:28 +0800 Subject: [PATCH] Take the review gate and the milestone publishing text from the template A milestone must be accepted with a Go review before code goes under src/ or tests/, each step is reviewed before the next, and a project that installs the sync-milestones workflow does not run sync-project.sh --apply for a reviewed milestone. The project's own sections (Related repositories, Languages, Credentials, rule 5) are unchanged. --- AGENTS.md | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index cb529eb..592b447 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -122,9 +122,12 @@ A change that spans repositories: ## Workflow order Business Case, Stakeholder Analysis, Project Plan, milestones, tasks synced as -issues, then code. Nothing goes under `src/` or `tests/` unless a milestone -document (`MIL-*`) is accepted and the task is a row in it (ideally a synced -issue). If those are missing, plan with the `project-planning` skill, show the +issues, then code, each step reviewed before the next (an artifact is done when +its `RC-*` says `Go` and its row is `Accepted`; code is reviewed against its +`qc-programming-*` checklist before the pull request). Nothing goes under `src/` +or `tests/` unless a milestone document (`MIL-*`) is accepted, its latest review +is a `Go`, and the task is a row in it (ideally a synced issue). If those are +missing, plan with the `project-planning` skill, show the dry-run output of `bash framework/scripts/sync-project.sh`, and stop. The rule is defined once in `framework/process/plan-first-gate.md`. @@ -135,7 +138,15 @@ A project with no baseline yet starts with the `create-project` skill. To enforce the gate at commit time, run `bash framework/scripts/install-git-hooks.sh --enable-plan-gate`: a commit that -changes `src/` or `tests/` then needs a `Task: MIL-NNN#N` trailer. +changes `src/` or `tests/` then needs a `Task: MIL-NNN#N` trailer for an +accepted, reviewed milestone. + +A milestone that is `Accepted` with a `Go` review is published to the git host by +the publish workflow after its merge, when the project has installed it +(`.gitea/workflows/sync-milestones.yml` or `.github/workflows/sync-milestones.yml`, +from `framework/templates/ci/`); do not run `sync-project.sh --apply` for it then. +Without the workflow, or for a milestone that is still `Proposed`, running +`--apply` is the user's decision. ## Languages